Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embed iframe when viewing a map #313

Merged

Conversation

boney-bun
Copy link

fix #152

@boney-bun
Copy link
Author

since we are using iframe, I've created a page to serve a particular map of interest accessible from the outside.
what do you think of the UI @gubuntu ?
below is the GIF.
the second illustration (http://localhost/9/embed) in the gif depicts what happened when a user embed the url to his/her site.

addembediframe152

@codecov
Copy link

codecov bot commented Aug 21, 2017

Codecov Report

Merging #313 into master-qgis_server will increase coverage by 0.03%.
The diff coverage is 83.33%.

Impacted file tree graph

@@                  Coverage Diff                   @@
##           master-qgis_server     #313      +/-   ##
======================================================
+ Coverage               49.07%   49.11%   +0.03%     
======================================================
  Files                     267      267              
  Lines                   20027    20050      +23     
  Branches                 2587     2589       +2     
======================================================
+ Hits                     9829     9847      +18     
- Misses                   9604     9607       +3     
- Partials                  594      596       +2
Impacted Files Coverage Δ
geonode/maps/urls.py 94.11% <100%> (+0.78%) ⬆️
geonode/maps/qgis_server_views.py 85.48% <80.95%> (-2.33%) ⬇️
geonode/maps/views.py 47.53% <0%> (-0.4%) ⬇️
geonode/maps/tests.py 98.53% <0%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63f051b...70de418. Read the comment docs.

@@ -34,10 +34,12 @@
if 'geonode.geoserver' in settings.INSTALLED_APPS:
new_map_view = 'new_map'
existing_map_view = 'map_view'
map_embed = 'map_embed'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean, there is a 'map_embed' functionality in Geoserver?

Copy link
Collaborator

@lucernae lucernae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the conflict first?

@gubuntu
Copy link

gubuntu commented Sep 13, 2017

LGTM (after fixing conflicts). And of course the url must be public and not localhost

@boney-bun
Copy link
Author

@lucernae yes, embed_map has been developed for geoserver.
thanks @lucernae @gubuntu
i'm going to merge them.

@boney-bun boney-bun merged commit 546c236 into kartoza:master-qgis_server Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grab an iframe embed snippet
3 participants