-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
embed iframe when viewing a map #313
embed iframe when viewing a map #313
Conversation
since we are using iframe, I've created a page to serve a particular map of interest accessible from the outside. |
Codecov Report
@@ Coverage Diff @@
## master-qgis_server #313 +/- ##
======================================================
+ Coverage 49.07% 49.11% +0.03%
======================================================
Files 267 267
Lines 20027 20050 +23
Branches 2587 2589 +2
======================================================
+ Hits 9829 9847 +18
- Misses 9604 9607 +3
- Partials 594 596 +2
Continue to review full report at Codecov.
|
geonode/maps/urls.py
Outdated
@@ -34,10 +34,12 @@ | |||
if 'geonode.geoserver' in settings.INSTALLED_APPS: | |||
new_map_view = 'new_map' | |||
existing_map_view = 'map_view' | |||
map_embed = 'map_embed' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean, there is a 'map_embed' functionality in Geoserver?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix the conflict first?
LGTM (after fixing conflicts). And of course the url must be public and not localhost |
fix #152