-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate KEDA scale logic with coming HPA scale to zero features #208
Comments
If I read it correctly, the scale to/from zero feature of HPA has been released in 1.16. Does it mean that it will replace the KEDA way of enabling/disabling the deployment any time soon? Does it make the whole controller obsolete? |
A few things to note
We should do it but just means one of the things KEDA does today it can offload to HPA, but would still need to do others |
Yes, I'm not questioning KEDA, I guess |
Makes sense. The other thing I want to check out (let me know if others know in meantime) is the polling interval and latency of HPA scaling from 0. In KEDA it’s configurable. Not sure if we’d leave KEDA as an option to still drive if it’s providing some additional features |
We should check how this impacts 2.0 /cc @zroubalik |
It's still alpha in kubernetes: https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/#feature-gates-for-alpha-or-beta-features (search for |
Sound like a plan! |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
/keep-alive |
Signed-off-by: Ahmed ElSayed <[email protected]>
* Welcome Apache Airflow as a user! Signed-off-by: Tom Kerkhove <[email protected]> * Resize image Signed-off-by: Tom Kerkhove <[email protected]> * Sort alphabetically Signed-off-by: Tom Kerkhove <[email protected]> * Fix users icon layout (kedacore#208) Signed-off-by: Ahmed ElSayed <[email protected]> * Welcome Apache Airflow as a user! Signed-off-by: Tom Kerkhove <[email protected]> Co-authored-by: Ahmed ElSayed <[email protected]>
Does having this issue open make sense? |
It depends - Do we align or still have our own approach? If the latter, why? |
HPA still doesn't support scale to 0, we deactivate the HPA according to official docs, but the scale to zero features aren't available yet in the HPA itself. We do that part with the operator (activation phase) |
This KEP is still active, kubernetes/enhancements#2022 Let's keep this issue opened to track this effort. |
Ok; I thought this was shipped already. |
kubernetes/kubernetes#74526
The text was updated successfully, but these errors were encountered: