Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-2021: Support scaling HPA to/from zero pods for object/external metrics #2022

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

KEP-2021: Support scaling HPA to/from zero pods for object/external metrics #2022

wants to merge 1 commit into from
+895 −0

Conversation

johanneswuerbach
Copy link

@johanneswuerbach johanneswuerbach commented Sep 26, 2020 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 26, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @johanneswuerbach!

It looks like this is your first PR to kubernetes/enhancements 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/enhancements has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 26, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @johanneswuerbach. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. labels Sep 26, 2020
This was referenced Sep 26, 2020
Open
Merged
Closed
@johanneswuerbach johanneswuerbach changed the title Initial KEP-2021 draft KEP: Support scaling HPA to/from zero pods for object/external metrics Sep 26, 2020
kikisdeliveryservice
kikisdeliveryservice reviewed Sep 27, 2020
View reviewed changes
Copy link
Member

@kikisdeliveryservice kikisdeliveryservice left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @johanneswuerbach

Enhancements Lead here, some notes on the the current PR:

The dir structure should be: keps/sig-autoscaling/2021-scale-from-zero/ (Note we put the issue number in the title now)

The current file 20200926-scale-from-zero.md should be renamed README.md and a kep.yaml should also be added.

More detail can be found here: https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template

Best,
Kirsten

@johanneswuerbach
Copy link
Author

@kikisdeliveryservice thank you, folder structure fixed.

@johanneswuerbach
Copy link
Author

johanneswuerbach commented Sep 30, 2020 •
edited
Loading

/assign @gjtempleton

I hoped to get the current state documented first, before we start talking about how we could move towards beta. Does that make sense?

@gjtempleton
Copy link
Member

Hey @johanneswuerbach

I think that's a good plan for now.

@jeffreybrowning
Copy link

@johanneswuerbach @gjtempleton how's this going so far? Can I be of any help?

@johanneswuerbach johanneswuerbach mentioned this pull request Oct 23, 2020
Merged
@johanneswuerbach
Copy link
Author

@jeffreybrowning yes. I assumed we could merge this KEP already as is to document the current state and then iterate on it towards beta. I'll try to present it at the next sig-autoscaling meeting to get some input and discuss next steps, but if you have any input I'm happy to incorporate it already.

@jeffreybrowning
Copy link

@johanneswuerbach missed autoscaling meeting today -- do you have clarity on next steps?

@johanneswuerbach
Copy link
Author

Me too, I assumed those are bi-weekly or are the meetings on-demand?

@jeffreybrowning
Copy link

In all honesty, it would have been my first one -- the work you started on this feature for beta has encouraged me to get involved and help you push this through.

It will really help using HPA + async job queue to scale down to 0 workers when not processing tasks.

@gjtempleton
Copy link
Member

Hey, the meetings are held weekly at 14:00 UTC, you can see more info including a link to the agenda if you want to raise it here.

I've raised this at a previous meeting, so the community's already aware this work has started, but it would be good to have some more in-depth discussion.

@johanneswuerbach
Copy link
Author

Thanks I got confused by the mention of biweekly here https://github.com/kubernetes/community/tree/master/sig-autoscaling#meetings and assumed the calendar invite is wrong. Will ask upfront next time :-)

@noahlz noahlz mentioned this pull request Nov 17, 2020
Open
@jeffreybrowning
Copy link

Pinging here. How's this enhancement coming along? What are next steps?

@jeffreybrowning
Copy link

Pinging back before the holidays hit.

What are next steps?

@zroubalik zroubalik mentioned this pull request Feb 2, 2023
Open
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 1, 2023
@MattJeanes
Copy link

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 1, 2023
@noahlz
Copy link

noahlz commented May 30, 2023

Anything we the community can do to help move this along?

@pbetkier
Copy link

@johnbelamaric could you have a look again as the author addressed your comments?

@rotilho
Copy link

rotilho commented Sep 10, 2023

Shouldn't someone re-request @johnbelamaric? Since he's still in the requested changes status it won't appear in his review request queue.

@wojtek-t wojtek-t self-assigned this Sep 11, 2023
@ahg-g
Copy link
Member

ahg-g commented Sep 12, 2023

/cc

@ofek
Copy link

ofek commented Oct 9, 2023

Has there been any update on this?

@johanneswuerbach
Copy link
Author

/assign @johnbelamaric

Anything I could do here to move this forward?

@noahlz
Copy link

noahlz commented Oct 12, 2023

We finally grew weary of waiting for this and migrated from HPA to KEDA. So far it's worked out pretty well.

Have already cut our AWS bill by ~30% (for the EKS cluster nodes), with more to come.

@zroubalik
Copy link

We finally grew weary of waiting for this and migrated from HPA to KEDA. So far it's worked out pretty well.

Have already cut our AWS bill by ~30% (for the EKS cluster nodes), with more to come.

Hi @noahlz! KEDA maintainer here. I would love to hear more about this, if you have a time, please. Could you please reach out (email on my GH account, Slack, LinkedIn, whatever) or tell me how can I connect with you?
Thanks!

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 22, 2024
@ofek
Copy link

ofek commented Jan 22, 2024

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 22, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 21, 2024
@MattJeanes
Copy link

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 21, 2024
@tcolgate
Copy link

It has been nearly 18 months since the KEP was updated after the previous review. I know these comments don't really help, but an update on the progress (or otherwise) of this would be great.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 20, 2024
@pierluigilenoci
Copy link

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 22, 2024
@MMeyer2808
Copy link

Can anyone tell why this pull request is not getting reviewed?
Maybe it's just missing the \lgtm label as done before by e.g. @josephburnett, such that @johnbelamaric is notified to approve the requested changes?

Once this PR has been reviewed and has the lgtm label, please ask for approval from johnbelamaric by writing /assign @johnbelamaric in a comment.

Would really love to see this feature flag reaching beta or GA :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kikisdeliveryservice kikisdeliveryservice kikisdeliveryservice left review comments

@josephburnett josephburnett josephburnett left review comments

@liggitt liggitt liggitt left review comments

@zroubalik zroubalik zroubalik left review comments

@noahlz noahlz noahlz left review comments

@elmiko elmiko elmiko left review comments

@mwielgus mwielgus mwielgus approved these changes

@gjtempleton gjtempleton Awaiting requested review from gjtempleton

@ahg-g ahg-g Awaiting requested review from ahg-g

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

Assignees

@josephburnett josephburnett

@gjtempleton gjtempleton

@deads2k deads2k

@johnbelamaric johnbelamaric

@wojtek-t wojtek-t

@mwielgus mwielgus

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.