Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ColorHandler logger #1515

Closed
Tracked by #1461
antonymilne opened this issue May 6, 2022 · 1 comment · Fixed by #1550
Closed
Tracked by #1461

Deprecate ColorHandler logger #1515

antonymilne opened this issue May 6, 2022 · 1 comment · Fixed by #1550
Assignees

Comments

@antonymilne
Copy link
Contributor

antonymilne commented May 6, 2022

Assuming that the RichHandler has become well-loved and accepted as the default logger, we should in all likelihood remove the ColorHandler provided in kedro.extras.logging. Possibly it's worth doing a quick bit of user research to check that no one feels strongly about keeping this in, but I'm pretty sure that no one really uses it and it will be redundant following the introduction of rich.

This is a breaking change - we need to add deprecation warnings in 0.18.x and then remove it in 0.19.

Note that when we have removed this and moved all extras.datasets out of kedro then all that will be left in kedro.extras is the ipython extension. Given that this namespace is probably changing to kedro.ipython, we will very nearly be at the point of being able to remove kedro.extras altogether 🥳

@merelcht
Copy link
Member

merelcht commented May 9, 2022

Discussed in sprint planning that we can just remove it and don't need to check with users first.

@SajidAlamQB SajidAlamQB self-assigned this May 16, 2022
@SajidAlamQB SajidAlamQB linked a pull request May 16, 2022 that will close this issue
5 tasks
@SajidAlamQB SajidAlamQB removed a link to a pull request May 17, 2022
5 tasks
@SajidAlamQB SajidAlamQB linked a pull request May 17, 2022 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants