Add deprecation warning to ColorHandler
#1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SajidAlamQB <[email protected]>
antonymilne
reviewed
May 16, 2022
There was a problem hiding this comment.
Please could you try specifying ColorHandler in your logging.yml file and see what this looks like when you do a kedro run? I wonder whether it will completely fill the screen with warnings and we will need to use a different filter.
Signed-off-by: SajidAlamQB <[email protected]>
This is what the warning looks like when we do
|
antonymilne
approved these changes
May 16, 2022
Signed-off-by: SajidAlamQB <[email protected]>
merelcht
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: SajidAlamQB [email protected]
Description
RichHandler will become the default logger, we need to remove the ColorHandler provided in
kedro.extras.loggingfor Kedro 0.19.0. This PR will add deprecation warnings to warn users of this fact.Related Issue: #1515
Development notes
Checklist
RELEASE.mdfile