Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ColorHandler logger #1550

Merged
merged 3 commits into from
May 18, 2022
Merged

Remove ColorHandler logger #1550

merged 3 commits into from
May 18, 2022

Conversation

SajidAlamQB
Copy link
Contributor

@SajidAlamQB SajidAlamQB commented May 17, 2022 •
edited by gitpod-io bot
Loading

Description

ColorHandler has been deprecated so this PR will remove it for kedro 0.19.0.

Related issue: #1515

Development notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes

@SajidAlamQB
remove colorhandler
e1ca2c1 
Signed-off-by: SajidAlamQB <[email protected]>
@SajidAlamQB SajidAlamQB requested a review from idanov as a code owner May 17, 2022 13:39
@SajidAlamQB SajidAlamQB self-assigned this May 17, 2022
@SajidAlamQB SajidAlamQB linked an issue May 17, 2022 that may be closed by this pull request
Deprecate ColorHandler logger #1515
Closed
@AhdraMeraliQB
Copy link
Contributor

I'm not sure what the convention is - should we be leaving the empty kedro/extras/logging file?

@SajidAlamQB
remove colorhandler test
5e72660 
Signed-off-by: SajidAlamQB <[email protected]>
@SajidAlamQB
Copy link
Contributor Author

I'm not sure what the convention is - should we be leaving the empty kedro/extras/logging file?

Does git still track empty directories I thought they get dropped once the directory is empty?

@AhdraMeraliQB
Copy link
Contributor

I'm not sure what the convention is - should we be leaving the empty kedro/extras/logging file?

Does git still track empty directories I thought they get dropped once the directory is empty?

Ah, looks like it's been dropped

antonymilne
antonymilne approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@antonymilne antonymilne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐ 🌟 ⭐ 🌟 ⭐ 🌟 ⭐

@AhdraMeraliQB git will indeed drop empty directories. The .gitkeep files in a few places in our repo are there for empty directories that we want to keep on git (which we don't in this case).

@SajidAlamQB
fix ci issues
47662e4 
Signed-off-by: SajidAlamQB <[email protected]>
@SajidAlamQB SajidAlamQB merged commit 3fcf0fa into develop May 18, 2022
@SajidAlamQB SajidAlamQB deleted the Remove-ColorHandler-logger branch May 18, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AhdraMeraliQB AhdraMeraliQB AhdraMeraliQB approved these changes

@antonymilne antonymilne antonymilne approved these changes

@idanov idanov Awaiting requested review from idanov

@merelcht merelcht Awaiting requested review from merelcht merelcht is a code owner

@yetudada yetudada Awaiting requested review from yetudada yetudada is a code owner

Assignees

@SajidAlamQB SajidAlamQB

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate ColorHandler logger
3 participants
@SajidAlamQB @AhdraMeraliQB @antonymilne