Add support for Tensorflow SparseTensors: merging layers. #925
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #925 +/- ##
===========================================
- Coverage 83.65% 72.14% -11.51%
===========================================
Files 318 318
Lines 28666 28735 +69
Branches 5464 5483 +19
===========================================
- Hits 23980 20731 -3249
- Misses 3168 6633 +3465
+ Partials 1518 1371 -147
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
hertschuh
force-pushed
the
sparse_merging_layers
branch
from
8e0d3c6
to
a447834
Compare
| @@ -32,7 +33,7 @@ class Add(Merge): | |||
| def _merge_function(self, inputs): | |||
| output = inputs[0] | |||
| for i in range(1, len(inputs)): | |||
| output = output + inputs[i] | |||
| output = ops.add(output, inputs[i]) | |||
There was a problem hiding this comment.
Very strange that TF cannot + sparse tensors...
There was a problem hiding this comment.
Indeed
3 x = tf.SparseTensor(indices=[[0, 0], [1, 2]], values=[2, 3], dense_shape=(3, 3))
----> 4 x + x
TypeError: unsupported operand type(s) for +: 'SparseTensor' and 'SparseTensor'
Only __div__, __mul__, __truediv__ are supported: https://www.tensorflow.org/api_docs/python/tf/sparse/SparseTensor
| ): | ||
| import tensorflow as tf | ||
|
|
||
| x = tf.SparseTensor( |
There was a problem hiding this comment.
Please also test execution/correctness for the sparse/dense mixture case, i.e. x sparse and y dense or inversely.
There was a problem hiding this comment.
Oh, that's exactly what this test is. x and y are sparse, z is dense, I verify x + z (sparse + dense), z + x (dense + sparse) and x + y (sparse + sparse).
I can add comments to clarify
There was a problem hiding this comment.
Reorganized the test to make it clear that the 3 combinations are tested.
| @@ -32,7 +33,7 @@ class Add(Merge): | |||
| def _merge_function(self, inputs): | |||
| output = inputs[0] | |||
| for i in range(1, len(inputs)): | |||
| output = output + inputs[i] | |||
| output = ops.add(output, inputs[i]) | |||
There was a problem hiding this comment.
Indeed
3 x = tf.SparseTensor(indices=[[0, 0], [1, 2]], values=[2, 3], dense_shape=(3, 3))
----> 4 x + x
TypeError: unsupported operand type(s) for +: 'SparseTensor' and 'SparseTensor'
Only __div__, __mul__, __truediv__ are supported: https://www.tensorflow.org/api_docs/python/tf/sparse/SparseTensor
| ): | ||
| import tensorflow as tf | ||
|
|
||
| x = tf.SparseTensor( |
There was a problem hiding this comment.
Oh, that's exactly what this test is. x and y are sparse, z is dense, I verify x + z (sparse + dense), z + x (dense + sparse) and x + y (sparse + sparse).
I can add comments to clarify
hertschuh
force-pushed
the
sparse_merging_layers
branch
from
a447834
to
2d246ad
Compare
Added `tf.SparseTensor` support for ops: - add - concatenate - maximum - minimum - multiply - subtract Added `tf.SparseTensor` support for merging layers: - Add - Average - Concatenate - Maximum - Minimum - Multiply - Subtract Note that the `Dot` merging layer will be addressed in a separate PR.
hertschuh
force-pushed
the
sparse_merging_layers
branch
from
2d246ad
to
4698c0e
Compare
Added
tf.SparseTensorsupport for ops:Added
tf.SparseTensorsupport for merging layers:Note that the
Dotmerging layer will be addressed in a separate PR.