Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only process PCAPs with httpreplay when tlsdump.log exists #2315

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Only process PCAPs with httpreplay when tlsdump.log exists #2315

merged 1 commit into from
Sep 10, 2024

Commits on Sep 10, 2024

  1. Only process PCAPs with httpreplay when tlsdump.log exists 

    These changes prevent PCAPs from being processed by httpreplay (Pcap2 processing module) when there are not TLS keys available. This is because httpreplay processing is very time intensive due to its pure-python implementation.

Httpreplay's core use is to decrypt TLS traffic so it can be processed by Suricata. If there are no TLS keys available, there is no requirement to use it for processing.

For context, when CAPE attempted to process a ~250MB PCAP with httpreplay, it took ~960 seconds. Without httpreplay, it took ~16 seconds.
    @josh-feather
    josh-feather committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    ea991c2 View commit details
    Browse the repository at this point in the history