Change LCIO::LCIO to LCIO::lcio #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
approved these changes
Jan 17, 2024
|
Not sure how the lcg based releases work with this change, since I don't think they have the target yet. |
|
From the logs I see some paths like: |
|
Ah right, those are clicdp nightlies and they come with the latest version of LCIO. Then it all makes sense. Thanks for checking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES
either this or we change the target in LCIO to be LCIO::LCIO; it seems in some repos like edm4hep it's all lowercase, in some others it's capitalized. In this case if anyone is using LCIO::LCIO they are using it through DD4hep and probably it's better to use the one from LCIO.
Using
LCIO::LCIOwas introduced in #298