Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMAKE: lcgeo to k4geo rename, k4geoConfig.cmake #298

Merged
merged 5 commits into from
Nov 16, 2023
Merged

CMAKE: lcgeo to k4geo rename, k4geoConfig.cmake #298

merged 5 commits into from
Nov 16, 2023

Conversation

andresailer
Copy link
Contributor

@andresailer andresailer commented Nov 9, 2023 •
edited
Loading

BEGINRELEASENOTES

  • CMake: The lcgeo project is renamed to k4geo, this also changes library names
  • CMake: add the creation of a k4geoConfig.cmake file

ENDRELEASENOTES

Would be good to have https://github.com/iLCSoft/LCIO/pull/177/files for the LCIO::LCIO target

@andresailer andresailer mentioned this pull request Nov 10, 2023
Merged
@giovannimarchiori giovannimarchiori mentioned this pull request Nov 14, 2023
Closed
@tmadlener
Copy link
Contributor

Am I missing something and the non-nightlies based CI workflow should have failed with these changes? That one picks up LCIO v02-19-01 and that should not have the target, right?

@andresailer
Copy link
Contributor Author

I was puzzled by the result as well, until I remembered that DD4hep shims the LCIO target in if it doesn't exist

https://github.com/AIDASoft/DD4hep/blob/ff4c726c90084b378cd9dc413ae2114e829002a7/cmake/DD4hepBuild.cmake#L903-L911

@andresailer andresailer enabled auto-merge (rebase) November 16, 2023 11:11
@andresailer andresailer merged commit c240627 into key4hep:master Nov 16, 2023
5 of 6 checks passed
@andresailer andresailer deleted the lc2k4 branch November 16, 2023 13:48
@andresailer andresailer mentioned this pull request Nov 20, 2023
Closed
@giovannimarchiori giovannimarchiori mentioned this pull request Nov 20, 2023
Merged
@jmcarcell jmcarcell mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmadlener tmadlener tmadlener approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andresailer @tmadlener