Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(developer): missing variables tests. everywhere. 🙀 #10773

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Feb 19, 2024

Fixes #10731

  • renamed MarkerTracker to SubstitutionTracker - with an expanded role
  • tests for missing variables
  • fixes for tests for missing variables

@keymanapp-test-bot skip

@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Feb 19, 2024

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot added this to the B17S2 milestone Feb 19, 2024
@srl295 srl295 linked an issue Feb 19, 2024 that may be closed by this pull request
@srl295 srl295 changed the title fix(developer): missing variables tests. everywhere. fix(developer): missing variables tests. everywhere. 🙀 Feb 19, 2024
Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good work

@srl295 srl295 merged commit c9be5d5 into beta Feb 20, 2024
5 checks passed
@srl295 srl295 deleted the developer/10731-err-undefined-var branch February 20, 2024 03:35
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.272-beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(developer): ldml not erroring with an undefined variable 🙀
3 participants