Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(developer): ldml not erroring with an undefined variable 🙀 #10731

Closed
srl295 opened this issue Feb 15, 2024 · 1 comment · Fixed by #10773
Closed

bug(developer): ldml not erroring with an undefined variable 🙀 #10731

srl295 opened this issue Feb 15, 2024 · 1 comment · Fixed by #10773
Assignees
@srl295
Labels
bug developer/
Milestone
B17S2

Comments

@srl295
Copy link
Member

srl295 commented Feb 15, 2024

Yes, #10505 caught this!

The following outputs 5:vars:undefined when it should throw a compile error.

    <key id="5" output="5:vars:${varsok}"/>
@srl295 srl295 self-assigned this Feb 15, 2024
@mcdurdin mcdurdin added this to the B17S2 milestone Feb 16, 2024
srl295 added a commit that referenced this issue Feb 19, 2024
@srl295
chore(developer): rename MarkerTracker to SubstitutionTracker
349168f 
- preparing to track variables also

For #10731
srl295 added a commit that referenced this issue Feb 19, 2024
@srl295
fix(developer): missing variables tests. everywhere.
470a62a 
Fixes #10731
@srl295 srl295 mentioned this issue Feb 19, 2024
Merged
@srl295 srl295 linked a pull request Feb 19, 2024 that will close this issue
fix(developer): missing variables tests. everywhere. 🙀 #10773
Merged
@srl295
Copy link
Member Author

srl295 commented Feb 22, 2024

fixed in #10773

@srl295 srl295 closed this as completed Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srl295 srl295

Labels
bug developer/
Projects
None yet
Milestone
B17S2
Development

Successfully merging a pull request may close this issue.

fix(developer): missing variables tests. everywhere. 🙀 keymanapp/keyman
2 participants
@srl295 @mcdurdin