Skip to content

Commit

Permalink
[8.x] [presentation team] Fix SASS mixed-declarations deprecation war…
Browse files Browse the repository at this point in the history
…nings (elastic#194721) (elastic#195115)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[presentation team] Fix SASS mixed-declarations deprecation warnings
(elastic#194721)](elastic#194721)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nathan
Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-04T15:57:51Z","message":"[presentation
team] Fix SASS mixed-declarations deprecation warnings
(elastic#194721)\n\ncloses
https://github.com/elastic/kibana/issues/190895,\r\nhttps://github.com/elastic/kibana/issues/190896,
and\r\nhttps://github.com/elastic/issues/190897\r\n\r\n##
Summary\r\n\r\n> Sass's behavior for declarations that appear after
nested\r\nrules will be changing to match the behavior specified by CSS
in an\r\nupcoming\r\nversion. To keep the existing behavior, move the
declaration above the\r\nnested\r\nrule. To opt into the new behavior,
wrap the declaration in & {}.\r\n\r\nPR moves declarations above the
nested rules.\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"6cf30e4523dcada4174cfaaeb591eded2a8198ee","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","v9.0.0","v8.16.0","backport:version"],"title":"[presentation
team] Fix SASS mixed-declarations deprecation
warnings","number":194721,"url":"https://github.com/elastic/kibana/pull/194721","mergeCommit":{"message":"[presentation
team] Fix SASS mixed-declarations deprecation warnings
(elastic#194721)\n\ncloses
https://github.com/elastic/kibana/issues/190895,\r\nhttps://github.com/elastic/kibana/issues/190896,
and\r\nhttps://github.com/elastic/issues/190897\r\n\r\n##
Summary\r\n\r\n> Sass's behavior for declarations that appear after
nested\r\nrules will be changing to match the behavior specified by CSS
in an\r\nupcoming\r\nversion. To keep the existing behavior, move the
declaration above the\r\nnested\r\nrule. To opt into the new behavior,
wrap the declaration in & {}.\r\n\r\nPR moves declarations above the
nested rules.\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"6cf30e4523dcada4174cfaaeb591eded2a8198ee"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194721","number":194721,"mergeCommit":{"message":"[presentation
team] Fix SASS mixed-declarations deprecation warnings
(elastic#194721)\n\ncloses
https://github.com/elastic/kibana/issues/190895,\r\nhttps://github.com/elastic/kibana/issues/190896,
and\r\nhttps://github.com/elastic/issues/190897\r\n\r\n##
Summary\r\n\r\n> Sass's behavior for declarations that appear after
nested\r\nrules will be changing to match the behavior specified by CSS
in an\r\nupcoming\r\nversion. To keep the existing behavior, move the
declaration above the\r\nnested\r\nrule. To opt into the new behavior,
wrap the declaration in & {}.\r\n\r\nPR moves declarations above the
nested rules.\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"6cf30e4523dcada4174cfaaeb591eded2a8198ee"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Nathan Reese <[email protected]>
  • Loading branch information
kibanamachine and nreese authored Oct 4, 2024
1 parent 76411ac commit bc44862
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
.dshSolutionToolbar__editorContextMenu {
@include euiScrollBar;
@include euiOverflowShadow;
max-height: 60vh;
overflow-y: scroll;
@include euiScrollBar;
@include euiOverflowShadow;
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@
height: 100%;

.canvasDebug__content {
@include euiScrollBar;
width: 100%;
height: 100%;
overflow: auto;
padding: $euiSize;
@include euiScrollBar;
}
}
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
.icvContainer__wrapper {
@include euiScrollBar;
min-height: 0;
flex: 1 1 0;
display: flex;
overflow: auto;
@include euiScrollBar;
}

.icvContainer {
Expand Down

0 comments on commit bc44862

Please sign in to comment.