Draft: Tentative fix for missing struct TypeInfo symbols

Reverting dlang#14844, which caused such missing TypeInfos, *and* making
sure the special TypeInfo members are fully analyzed and ready for
codegen (otherwise hitting an assertion).

compiler/src/dmd/expressionsem.d

@@ -6919,17 +6919,7 @@ private extern (C++) final class ExpressionSemanticVisitor : Visitor
             // Handle this in the glue layer
             e = new TypeidExp(exp.loc, ta);
 
-            bool genObjCode = true;
-
-            // https://issues.dlang.org/show_bug.cgi?id=23650
-            // We generate object code for typeinfo, required
-            // by typeid, only if in non-speculative context
-            if (sc.flags & SCOPE.compile)
-            {
-                genObjCode = false;
-            }
-
-            e.type = getTypeInfoType(exp.loc, ta, sc, genObjCode);
+            e.type = getTypeInfoType(exp.loc, ta, sc);
             semanticTypeInfo(sc, ta);
 
             if (ea)

compiler/src/dmd/frontend.h

@@ -8208,7 +8208,7 @@ extern bool tpsemantic(TemplateParameter* tp, Scope* sc, Array<TemplateParameter
 
 extern bool genTypeInfo(Expression* e, const Loc& loc, Type* torig, Scope* sc);
 
-extern Type* getTypeInfoType(const Loc& loc, Type* t, Scope* sc, bool genObjCode = true);
+extern Type* getTypeInfoType(const Loc& loc, Type* t, Scope* sc);
 
 extern bool isSpeculativeType(Type* t);
 

compiler/src/dmd/todt.d

@@ -1437,6 +1437,13 @@ private extern (C++) class TypeInfoDtVisitor : Visitor
                 /* ti.toObjFile() won't get called. So, store these
                  * member functions into object file in here.
                  */
+
+                if (sd.semanticRun < PASS.semantic3done)
+                {
+                    import dmd.semantic3 : semanticTypeInfoMembers;
+                    semanticTypeInfoMembers(sd);
+                }
+
                 if (sd.xeq && sd.xeq != StructDeclaration.xerreq)
                     toObjFile(sd.xeq, global.params.multiobj);
                 if (sd.xcmp && sd.xcmp != StructDeclaration.xerrcmp)

compiler/src/dmd/typinf.d

@@ -103,14 +103,13 @@ extern (C++) bool genTypeInfo(Expression e, const ref Loc loc, Type torig, Scope
  *      loc = the location for reporting line nunbers in errors
  *      t   = the type to get the type of the `TypeInfo` object for
  *      sc  = the scope
- *      genObjCode = if true, object code will be generated for the obtained TypeInfo
  * Returns:
  *      The type of the `TypeInfo` object associated with `t`
  */
-extern (C++) Type getTypeInfoType(const ref Loc loc, Type t, Scope* sc, bool genObjCode = true)
+extern (C++) Type getTypeInfoType(const ref Loc loc, Type t, Scope* sc)
 {
     assert(t.ty != Terror);
-    if (genTypeInfo(null, loc, t, sc) && genObjCode)
+    if (genTypeInfo(null, loc, t, sc))
     {
         // Find module that will go all the way to an object file
         Module m = sc._module.importedFrom;

compiler/src/dmd/typinf.h

@@ -19,7 +19,7 @@ class FuncDeclaration;
 class ScopeDsymbol;
 
 bool genTypeInfo(Expression *e, const Loc &loc, Type *torig, Scope *sc);
-Type *getTypeInfoType(const Loc &loc, Type *t, Scope *sc, bool genObjCode = true);
+Type *getTypeInfoType(const Loc &loc, Type *t, Scope *sc);
 bool isSpeculativeType(Type *t);
 bool builtinTypeInfo(Type *t);
 FuncDeclaration *findGetMembers(ScopeDsymbol *dsym);

compiler/src/tests/cxxfrontend.cc

@@ -1663,7 +1663,7 @@ void test_typinf(Expression *e, const Loc &loc, Type *t, Scope *sc)
 {
     // Link tests
     genTypeInfo(e, loc, t, sc);
-    getTypeInfoType(loc, t, sc, false);
+    getTypeInfoType(loc, t, sc);
     isSpeculativeType(t);
     builtinTypeInfo(t);
 }