Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs Icon Ripple and Title #3668

Closed
Sagar0-0 opened this issue Jan 13, 2024 · 8 comments · Fixed by #3689
Closed

Tabs Icon Ripple and Title #3668

Sagar0-0 opened this issue Jan 13, 2024 · 8 comments · Fixed by #3689
Assignees
Milestone

Comments

@Sagar0-0
Copy link
Contributor

Describe the bug

The tab icon in the Reader is not having a ripple effect and a title which is bad for accessibility.

Expected behavior

Add Ripple and title/desciption

Steps to reproduce the behavior:

  1. Open the reader
  2. See in the topbar
    -->

Screenshots

photo_6131796836109891986_y

Environment

  • Version of Kiwix Android : 3.9.1
  • Device : REALME GT NEO 3T
  • OS version : 13

Logs

@satvik2131
Copy link

do anyone working on this project ?
@Sagar0-0

@Sagar0-0
Copy link
Contributor Author

I need a maintainer to verify this issue before diving in.

@satvik2131
Copy link

oh okay , got it .

@kelson42
Copy link
Collaborator

@MohitMaliFtechiz @gouri-panda What is the strategy regarding this ripple effect? Do we have it in other cases? If "no" why?

@kelson42 kelson42 added this to the 3.11.0 milestone Jan 30, 2024
@gouri-panda
Copy link
Collaborator

@kelson42 The Ripple affect contributes to a more engaging and user-friendly experience.The visual feedback animation that occurs when a user taps a touchable UI element. It enhances UX by providing immediate feedback .

Do we have it in other cases? If "no" why?

No, we haven't used it for another cases except when we click/long click the zim files We always aim for simple UX. Having this adds a little bit of complexity to our code that's why we didn't focus on this area.

@Sagar0-0
Copy link
Contributor Author

@gouri-panda can you explain what kind of complexity? I have added the ripple and ready with a PR.

Sagar0-0 added a commit to Sagar0-0/kiwix-android that referenced this issue Jan 31, 2024
@kelson42
Copy link
Collaborator

The fix seems indeed trivial, but is that really an improvment? What are the criterias to put such an effect (or not)?

@kelson42 kelson42 modified the milestones: 3.11.0, 3.10.0 Jan 31, 2024
@MohitMaliFtechiz
Copy link
Collaborator

MohitMaliFtechiz commented Feb 1, 2024

@kelson42 Yes this is an improvement. It improves the user experience and gives clarity of Interaction where the user clicks because it gives immediate feedback from the UI so the user can know if the click happened or not. Also, it is advisable to use a ripple effect to follow the Material design guidelines. e.g. we have the ripple effect on the search icon and on the overflow menu.

Sagar0-0 added a commit to Sagar0-0/kiwix-android that referenced this issue Feb 2, 2024
Sagar0-0 added a commit to Sagar0-0/kiwix-android that referenced this issue Feb 3, 2024
Sagar0-0 added a commit to Sagar0-0/kiwix-android that referenced this issue Feb 7, 2024
Sagar0-0 added a commit to Sagar0-0/kiwix-android that referenced this issue Feb 10, 2024
Sagar0-0 added a commit to Sagar0-0/kiwix-android that referenced this issue Feb 10, 2024
Sagar0-0 added a commit to Sagar0-0/kiwix-android that referenced this issue Feb 10, 2024
Sagar0-0 added a commit to Sagar0-0/kiwix-android that referenced this issue Feb 10, 2024
Sagar0-0 added a commit to Sagar0-0/kiwix-android that referenced this issue Feb 15, 2024
Sagar0-0 added a commit to Sagar0-0/kiwix-android that referenced this issue Feb 15, 2024
Sagar0-0 added a commit to Sagar0-0/kiwix-android that referenced this issue Feb 15, 2024
Sagar0-0 added a commit to Sagar0-0/kiwix-android that referenced this issue Feb 15, 2024
Sagar0-0 added a commit to Sagar0-0/kiwix-android that referenced this issue Feb 15, 2024
Sagar0-0 added a commit to Sagar0-0/kiwix-android that referenced this issue Feb 15, 2024
kelson42 added a commit that referenced this issue Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants