-
-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tabs Icon Ripple and Title #3668
Comments
do anyone working on this project ? |
I need a maintainer to verify this issue before diving in. |
oh okay , got it . |
@MohitMaliFtechiz @gouri-panda What is the strategy regarding this ripple effect? Do we have it in other cases? If "no" why? |
@kelson42 The Ripple affect contributes to a more engaging and user-friendly experience.The visual feedback animation that occurs when a user taps a touchable UI element. It enhances UX by providing immediate feedback .
No, we haven't used it for another cases except when we click/long click the zim files We always aim for simple UX. Having this adds a little bit of complexity to our code that's why we didn't focus on this area. |
@gouri-panda can you explain what kind of complexity? I have added the ripple and ready with a PR. |
The fix seems indeed trivial, but is that really an improvment? What are the criterias to put such an effect (or not)? |
@kelson42 Yes this is an improvement. It improves the user experience and gives clarity of Interaction where the user clicks because it gives immediate feedback from the UI so the user can know if the click happened or not. Also, it is advisable to use a ripple effect to follow the Material design guidelines. e.g. we have the ripple effect on the |
Describe the bug
The tab icon in the Reader is not having a ripple effect and a title which is bad for accessibility.
Expected behavior
Add Ripple and title/desciption
Steps to reproduce the behavior:
-->
Screenshots
Environment
Logs
The text was updated successfully, but these errors were encountered: