#3668 Ripple in Tabs Icon

[Sagar0-0]

Fixes #3668

Added background for ripple

Screenshots

[Sagar0-0]

@kelson42 @MohitMaliFtechiz I am not able to add a reviewer to this PR, so asking for it here.

[codecov]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f65787b) 50.63% compared to head (b924daa) 51.59%.

Files	Patch %	Lines
.../kiwix/kiwixmobile/core/main/CoreReaderFragment.kt	80.00%	0 Missing and 1 partial ⚠️
...n/java/org/kiwix/kiwixmobile/core/main/MainMenu.kt	83.33%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #3689      +/-   ##
============================================
+ Coverage     50.63%   51.59%   +0.96%     
- Complexity     1196     1233      +37     
============================================
  Files           288      288              
  Lines         10851    10867      +16     
  Branches       1454     1456       +2     
============================================
+ Hits           5494     5607     +113     
+ Misses         4424     4300     -124     
- Partials        933      960      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[MohitMaliFtechiz]

@Sagar0-0 Thanks 🎉

[gouri-panda]

@Sagar0-0 Thanks 🎉 But I can't think why I can't access the PR. But I think it's only affect in the tab switcher not the entire tab bar which the ticket was created for.

[Sagar0-0]

Can you explain me further regarding the expected behaviour and how it is different from current implementation?

[MohitMaliFtechiz]

But I can't think why I can't access the PR.

@gouri-panda It is a fork. You can do one thing, clone the Sagar's repo, and then you can access this PR.

But I think it's only affect in the tab switcher not the entire tab bar which the ticket was created for.
Can you explain me further regarding the expected behaviour and how it is different from current implementation?

@Sagar0-0, @gouri-panda pointing to fix the full tab behavior, however, this ticket is only for the tab icon in toolbar. But @gouri-panda is right, we should fix the whole behavior of the tab in this PR. @Sagar0-0 Please add the title on the close all tab button, and add the ripple effect and title to the close image of the recycler view item.

[Sagar0-0]

On it

[Sagar0-0]

setHomeActionContentDescription("Add") is not working, got any idea why?

[Sagar0-0]

LGTM

[gouri-panda]

@Sagar0-0 Please don't mark conservation as resolved yourself. Only those who created should close these.

[MohitMaliFtechiz]

Just a small change needed, then we are good to merge.

[MohitMaliFtechiz]

@Sagar0-0 Thanks 🎉, @kelson42 LGTM.