Relies on libkiwix 14.0.0 #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelson42
force-pushed
the
libkiwix-14.0.0
branch
from
ccd8230
to
cdc76a3
Compare
|
@BPerlakiH I guess this is your turn now to complete this PR :( |
balazs-vimn
approved these changes
Oct 11, 2024
|
@BPerlakiH Hmmm.... the CI does not pass... we can not merge like this |
kelson42
force-pushed
the
libkiwix-14.0.0
branch
from
a408ab5
to
a4ad439
Compare
rgaudin
reviewed
Oct 18, 2024
Brewfile
Outdated
| @@ -4,7 +4,7 @@ brew "curl" | |||
|
|
|||
| at_exit do | |||
| system "pre-commit install" | |||
| system "curl -L -o - https://download.kiwix.org/release/libkiwix/libkiwix_xcframework-13.1.0-4.tar.gz | tar -x --strip-components 2" | |||
| system "curl -L -o - https://download.kiwix.org/release/libkiwix/libkiwix_xcframework-14.0.0.tar.gz | tar -x --strip-components 2" | |||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1004 +/- ##
==========================================
+ Coverage 38.27% 39.35% +1.07%
==========================================
Files 118 118
Lines 6879 6879
==========================================
+ Hits 2633 2707 +74
+ Misses 4246 4172 -74 ☔ View full report in Codecov by Sentry. |
|
@rgaudin @BPerlakiH CI is green! Does that mean we can merge? |
|
I am testing it right now... |
|
Seems to be OK to me. Works on simulator, iPhone real device, macOS:
|
BPerlakiH
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #984