Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of libkiwix14 #984

Closed
kelson42 opened this issue Sep 18, 2024 · 10 comments · Fixed by #1004
Closed

Add support of libkiwix14 #984

kelson42 opened this issue Sep 18, 2024 · 10 comments · Fixed by #1004
Assignees
Labels
Milestone

Comments

@kelson42
Copy link
Contributor

Libkiwix 14 is almost over, we should use it when released.

Blocked by kiwix/libkiwix#1081

@kelson42 kelson42 added the task label Sep 18, 2024
@kelson42 kelson42 added this to the 3.6.0 milestone Sep 18, 2024
@kelson42 kelson42 changed the title Add support of libkiwix13 Add support of libkiwix14 Sep 18, 2024
@kelson42
Copy link
Contributor Author

@BPerlakiH Can you please make a draft PR and check that everything is OK before the libkiwix 14 release (using nightly)?

@BPerlakiH
Copy link
Collaborator

BPerlakiH commented Oct 11, 2024

@kelson42 from the errors on the PR it seems to me that the iOS simulator is not included in the target framework build of libkiwix.

Also it is substantially smaller than the former package here (13.1.0 vs 14.0.0):
https://download.kiwix.org/release/libkiwix/

[ ] libkiwix_xcframework-13.1.0.tar.gz 2024-02-25 15:17 195M
[ ] libkiwix_xcframework-14.0.0.tar.gz 2024-10-11 14:37 59M

I think it needs a re-build.

@kelson42
Copy link
Contributor Author

@rgaudin The explanation of @BPerlakiH seems the most logical... but not clear where is the regression. We should not have touch that part, but I suspect that somehow a something has been broken. Could you please have a look please?

@rgaudin
Copy link
Member

rgaudin commented Oct 12, 2024

Image

No, it seems all archs are present but all are significantly smaller. Looks like an embedded-dependency issue

@kelson42
Copy link
Contributor Author

@rgaudin Can we easily have a look to latest working and see where is the difference?

@rgaudin
Copy link
Member

rgaudin commented Oct 12, 2024

Not sure exactly but building raises this ; which is exactly what the CI logs shows

Image

Are we depending on libgss?

@kelson42
Copy link
Contributor Author

Kind of suspect the regression is around libcurl... and this commit might be interesting kiwix/kiwix-build@23a6b93

@rgaudin
Copy link
Member

rgaudin commented Oct 17, 2024

This is fixed at kiwix/kiwix-build#765.

Once @kelson42 merges it and we have a nightly, we'll be able to test. It will require adding - sdk: SystemConfiguration.framework to the project.yml

@BPerlakiH
Copy link
Collaborator

BPerlakiH commented Oct 17, 2024

SystemConfiguration.framework is added now, waiting for the new build, as with the current one it's still not compiling (after re-reading the comments, I suppose it was expected):
Image

@rgaudin
Copy link
Member

rgaudin commented Oct 18, 2024

@BPerlakiH yes that was expected but since the nightly workflow ran so I tested with https://download.kiwix.org/nightly/2024-10-18/libkiwix_xcframework-2024-10-18.tar.gz but that didn't work.

On a second thought, that's normal as the fix was not in libkiwix (which main branch is compiled in the nightly) but in the libcurl dependency. We thus need to request a new revision of the dependencies (as those are cached). @kelson42 can you do it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants