Bottom bar should be not displayed in settings

[kelson42]

The buttons do not not work if settings are displayed and it does not make sense here.

[Jaifroid]

Thanks, @kelson42 . This should probably be applied in Kiwix JS if @mossroy agrees and then ported to Kiwix JS Windows, since the code is common to both apps.

[kelson42]

@Jaifroid Good. I'm not always sure where the problem should be fixed, so in that case I used to report it where I see it first. If you want you can move tickets easily to kiwix-js with https://github-issue-mover.appspot.com/.

[Jaifroid]

So, I've got rid of the bottom toolbar when the Settings and the About tabs are open.

There is one navigation issue that arises with this: the text on the About page is quite long, and the up-arrow on the bottom toolbar can be used to navigate quickly back to the top. I'm not sure how important this is, as on a phone it's not hard to scroll rapidly back up, and on a non-touchscreen PC, Ctrl-Home or PgUp will take you back quickly. However, I thought I should flag it here, as it may have implications for kiwix/kiwix-js#337 (@mossroy).

The other navigation issue is that the home icon is a quick shortcut for going back to the landing page. Clicking the Kiwix / Wikivoyage / WikiMed icon on the top toolbar does the same thing, but it is less discoverable. I've mitigated against this by adding a couple of Return to PageName... links on the About page (there were already a couple on the Settings page) -- see screenshot below. These Return to... links were always a kludge to provide a way of returning to the currently loaded article without having to return to the landing page and search for it again. This is a known issue in kiwix/kiwix-js#127.

Basically I think there's a trade-off between more screen real estate and ease of navigation. However, I think I'm going to ship with this in Kiwix JS Windows 0.9.9 beta and see if people squeal....

[kelson42]

@Jaifroid

I do not think the lack of "back to top" is a real problem. In worse case, if its, a "back to top" bottom bar similar to the one on Android could be build IMO... But again, I would be really surprise if that becomes a recurrent feature requests in user's feedbacks.

Regarding the ability to come back to the content, I think implementing #44 would also help to get that problem fixed.

[Jaifroid]

This issue is now implemented in 0.99 in Kiwix JS and in WikiMed (both versions in the Store), but not yet in Wikivoyage (update is in code, but not yet shipped).

I'm not entirely happy with the ergonomics, as returning to the article content from the Config or About pages requires two-handed use on large mobile screens when the bottom bar is hidden. But this can be discussed in kiwix/kiwix-js#337 . I'm closing this issue.