Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings top bar button stays "clicked" #44

Closed
kelson42 opened this issue Jan 14, 2018 · 4 comments
Closed

Settings top bar button stays "clicked" #44

kelson42 opened this issue Jan 14, 2018 · 4 comments
Assignees
Labels
Milestone

Comments

@kelson42
Copy link
Contributor

It is quite easy to get this buttong stuck as "clicked" status. This is for example easy to achieve by clicking on it during a page loading. I suspect here the whole handling of getting settings displayed and exiting is not so good. Exiting settings is done through a third party link, and I think we should at a least also work by clicking "out" the settings button.

@kelson42 kelson42 added the bug label Jan 14, 2018
@Jaifroid Jaifroid self-assigned this Jan 14, 2018
@Jaifroid Jaifroid added this to the Release 1.0 milestone Jan 14, 2018
@Jaifroid
Copy link
Member

I think you're right -- the switching between the different menus isn't ideal. I can (and will) add some code to prevent the sticking here (some buttons such as the random button don't hide the settings page properly). But again a more generalized look at the menu switching should be undertaken in Kiwix JS. There is some discussion at kiwix/kiwix-js#304.

@Jaifroid
Copy link
Member

Jaifroid commented Feb 4, 2018

@kelson42 I've already implemented the "unsticking" part of this, but I haven't yet implemented a "clicking out" of the button to return you to the article you're reading. Not sure how intuitive that would be, but I agree it's a good idea to have it.

@Jaifroid
Copy link
Member

This issue is now fixed in 0..9.9 beta in WikiMed and Kiwix JS. It has not yet been pushed to Wikivoyage. But I think the issue can be closed.

@kelson42
Copy link
Contributor Author

@Jaifroid I confirm that this seems to work perfectly on my Lumia.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants