-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings top bar button stays "clicked" #44
Comments
I think you're right -- the switching between the different menus isn't ideal. I can (and will) add some code to prevent the sticking here (some buttons such as the random button don't hide the settings page properly). But again a more generalized look at the menu switching should be undertaken in Kiwix JS. There is some discussion at kiwix/kiwix-js#304. |
@kelson42 I've already implemented the "unsticking" part of this, but I haven't yet implemented a "clicking out" of the button to return you to the article you're reading. Not sure how intuitive that would be, but I agree it's a good idea to have it. |
This issue is now fixed in 0..9.9 beta in WikiMed and Kiwix JS. It has not yet been pushed to Wikivoyage. But I think the issue can be closed. |
@Jaifroid I confirm that this seems to work perfectly on my Lumia. |
It is quite easy to get this buttong stuck as "clicked" status. This is for example easy to achieve by clicking on it during a page loading. I suspect here the whole handling of getting settings displayed and exiting is not so good. Exiting settings is done through a third party link, and I think we should at a least also work by clicking "out" the settings button.
The text was updated successfully, but these errors were encountered: