Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Service Worker the default if the app is being accessed as a PWA #808

Closed
Jaifroid opened this issue Jan 29, 2022 · 0 comments · Fixed by #809
Closed

Make Service Worker the default if the app is being accessed as a PWA #808

Jaifroid opened this issue Jan 29, 2022 · 0 comments · Fixed by #809
Assignees
Milestone

Comments

@Jaifroid
Copy link
Member

This would be a step towards #196. It would be a very short PR (probably one-liner). It makes no sense that accessing the app as a PWA -- which requires Service Worker by definition -- opens the app in JQuery mode. So, the idea here is that if the app is being accessed from http(s): and Service Worker is available, it should open in SW mode by default (the user can still change back to JQuery).

This would not yet affect our extensions, which would open in JQuery mode by default.

This would also fix #801 implicitly. I'd recommend this being part of release 3.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant