-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default to SW mode when accessing app as PWA #809
Default to SW mode when accessing app as PWA #809
Conversation
Interesting that all tests passed. I was expecting the secure browser tests to fail due to differences between jQuery and SW mode, but clearly the differences are immaterial. That's good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, even if directly accessing the PWA is not the main usage
That's very interesting. |
I think it might depend on whether we can see the console output in the tests snapshots. If they are running in a secure context and the browser is capable of supporting SW mode, they should launch in SW mode with this PR. |
So I guess this is ready to merge. I've tested on Firefox & Edge Chromium from localhost. You have to reset the app to see what it defaults to when there is no |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK for me
Fixes #808 and #801. Basically a one-liner, but formatted as two for legibility 😊.
EDIT: It will be interesting to see what effect this has on the secure browser tests...