Fix scrapers to remove inline javascript in ZIM files

[mossroy]

As discussed in #789, browser extensions now enforce some CSP that block inline javascript.
And it might happen in some other contexts, too.

Here is a list of affected scrapers that should be fixed (most critical first):

• Remove inline JavaScript to comply with some CSPs openzim/gutenberg#145 : main page unusable, other pages seem to work well
• Remove inline javascript to comply with some CSP openzim/nautilus#34 : main mage unusable, other pages seem to work well
• Remove inline javascript to comply with some CSP openzim/phet#134 : main page unusable, other pages seem to work well
• Remove inline Javascript openzim/phet#152
• Remove inline javascript to comply with some CSP openzim/youtube#154 : "only" affects the drop-down list of the home page, and loading of the webp-polyfill
• Remove inline javascript to comply with some CSP openzim/openedx#168: a lot of inline javascript blocks + some "onclick" attributes
• Remove inline javascript to comply with some CSP openzim/sotoki#249 : several inline javascript blocks + some "onerror" attributes on some images
• Remove inline javascript to comply with some CSP openzim/mwoffliner#1578 : minor. It seems to block webp-polyfill related code
• Remove inline javascript to comply with some CSP openzim/wikihow#108 : minor. It blocks some video-related javascript
• Remove inline javascript to comply with some CSP openzim/ted#128 : minor. It seems to block webp-polyfill related code
• Remove inline javascript to comply with some CSP openzim/kolibri#39 : minor. It seems to block webp-polyfill related code

NB: please tick the items in the list only when it has been tested with Kiwix-js with a public ZIM file

[Jaifroid]

It looks like we might have got as far as we can with this issue. It has become less critical now that we are forced (due to Manifest V3) to use the PWA workaround for the Chromium extension. However, "conceptually" it would be nice to fix the remaining three scrapers. @kelson42 Do you think this issue should now be closed (but leave the unresolved three issues listed above still open)?

[kelson42]

Still something to finish, now officially on the plate of @benoit74 ;)

[benoit74]

kolibri is now done with openzim/kolibri#43, will probably be released very soon with openzim/kolibri#44, please tick the box (I don't have sufficient rights ;o))

[Jaifroid]

@benoit74 Wonderful, many thanks! Box duly ticked!

[benoit74]

@Jaifroid : I forgot to mention it, you can tick openedx as well

As discussed with @kelson42, gutenberg is on my plate, I plan to do this in August / early September together will all remaining issues of 2.1.0

[Jaifroid]

Thank you very much, @benoit74. I've ticked OpenEdx and look forward to Gutenberg in due course!

[benoit74]

@Jaifroid: Could you please test:

• gutenberg : https://www.swisstransfer.com/d/e0c06fef-396f-48a0-af13-44fcee91965d (very small ZIM with only few books but multiple authors, bookshelves, languages so we can test most functionalities)
• kolibri : https://mirror.download.kiwix.org/zim/.hidden/dev/africanstorybook.org_en_all_2023-07.zim

Unfortunately I cannot provide a ZIM to test openedx because we have no more active recipes on Zimfarm + other issues preventing the scraper to operate properly on recent openedx versions (openzim/openedx#175)

[kelson42]

@benoit74 Thank you very to have fixed the last scrapers. I can't wait to see that ticket closed!

[Jaifroid]

@benoit74 Thank you very much indeed. I've tested the new Gutenberg ZIM in the Chromium extension in the "Service Worker Local" mode, and I can confirm that books now display and load correctly, and all JS seems to be functioning as expected.

I'm still downloading the African Story Book, so will report back on that, but it's looking great!

[Jaifroid]

I've now tested the African Story Book ZIM in Chromium with Service Worker Local mode (this is the mode where inline JS is blocked), and I confirm that it all looks good. The EPUB viewer, which I think is the main piece of dynamic code here, works perfectly with this version.

@benoit74 Many thanks indeed. So I think we can finally close this issue if everyone is happy. 😊

[Jaifroid]

Thanks once again!