Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade + pin all dependencies #44

Merged
merged 5 commits into from
Jul 13, 2023
Merged

Upgrade + pin all dependencies #44

merged 5 commits into from
Jul 13, 2023

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Jul 10, 2023

  • Upgrade dependencies to latest version (especially python-scraper lib), including adapations for zimscraperlib 3
  • Pin all dependencies as planned in our new rules

@kelson42
Copy link
Contributor

I recommend to create this kind of ticket before starting a release and put this ticket in the current milestone (which gather all issues/tickets fixed/impelemented in the release).

@benoit74
Copy link
Collaborator Author

I agree ! Could you explain what has to be done for "Advertise this new version" for scrappers ? A message on slack #scrappers ?

Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a release PR ; this is a scraperlib upgrade one. Please remove the version from changelog and rename the PR accordingly.
Another change I'd like to see is using pinned versions for all dependencies. According to our sacred book, we should stop using ranges for scrapers.

As @kelson42 mentioned, we usually create one such ticket per release, attached to the milestone it is supposed to end.
Release itself is usually composed of:

  • A version change + changelog update commit on main: release version and date at least but might include catch-up for changes that did not update the changelog
  • A tag on that commit
  • A Github release (manually created in UI). Some scrapers have been updated to trigger publication on Gihub release event, some are still using the previous behavior (on tag event)

Once this PR is merged, you can release yourself, directly on main, as you are the maintainer.

kolibri2zim/scraper.py Outdated Show resolved Hide resolved
@rgaudin
Copy link
Member

rgaudin commented Jul 11, 2023

Oh and another step for scrapers is requesting me to update all ZF recipes to that new version.
If the release introduces CLI changes (of ZF interest, the --nodes-id one here we don't want to use on ZF), a PR on zimfarm must be created to update the definition obviously.

@benoit74 benoit74 changed the title Release v1.1.0 Upgrade + pin all dependencies Jul 13, 2023
requirements.txt Outdated Show resolved Hide resolved
@benoit74 benoit74 added this to the 1.1.0 milestone Jul 13, 2023
@benoit74 benoit74 self-assigned this Jul 13, 2023
@benoit74 benoit74 requested a review from rgaudin July 13, 2023 07:32
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ; except the dependencies ; see extensive inline comment.

requirements.txt Outdated Show resolved Hide resolved
@benoit74 benoit74 merged commit 3adfca2 into main Jul 13, 2023
@benoit74 benoit74 deleted the release_1_1_0 branch July 13, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants