-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade + pin all dependencies #44
Conversation
benoit74
commented
Jul 10, 2023
•
edited
Loading
edited
- Upgrade dependencies to latest version (especially python-scraper lib), including adapations for zimscraperlib 3
- Pin all dependencies as planned in our new rules
I recommend to create this kind of ticket before starting a release and put this ticket in the current milestone (which gather all issues/tickets fixed/impelemented in the release). |
I agree ! Could you explain what has to be done for "Advertise this new version" for scrappers ? A message on slack #scrappers ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a release PR ; this is a scraperlib upgrade one. Please remove the version from changelog and rename the PR accordingly.
Another change I'd like to see is using pinned versions for all dependencies. According to our sacred book, we should stop using ranges for scrapers.
As @kelson42 mentioned, we usually create one such ticket per release, attached to the milestone it is supposed to end.
Release itself is usually composed of:
- A version change + changelog update commit on main: release version and date at least but might include catch-up for changes that did not update the changelog
- A tag on that commit
- A Github release (manually created in UI). Some scrapers have been updated to trigger publication on Gihub
release
event, some are still using the previous behavior (ontag
event)
Once this PR is merged, you can release yourself, directly on main, as you are the maintainer.
Oh and another step for scrapers is requesting me to update all ZF recipes to that new version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ; except the dependencies ; see extensive inline comment.