Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update active content warning detection #890

Closed
Jaifroid opened this issue Sep 24, 2022 · 1 comment
Closed

Update active content warning detection #890

Jaifroid opened this issue Sep 24, 2022 · 1 comment
Assignees
@Jaifroid
Labels
enhancement user interface

Comments

@Jaifroid
Copy link
Member

Because some of the scrapers have been / are being fixed in #865, the Active Content Warning we show to users of jQuery is not always reliably detecting active content. We actually relied on finding script tags with in-line JS for part of the detection. Now this is being removed, we need to detect specific scripts (and exempt those ZIMs which still run well in jQuery mode even though they might have some scripts).

I have opened #889 to deal with this.
@Jaifroid Jaifroid self-assigned this Sep 24, 2022
Jaifroid added a commit that referenced this issue Sep 25, 2022
@Jaifroid
Update active content detection due to removal of inline JS #890 (#889)
77da9be
@Jaifroid
Copy link
Member Author

Fixed via #889.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jaifroid Jaifroid

Labels
enhancement user interface
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Jaifroid