Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink how we integrate resources in binaries. #31

Open
mgautierfr opened this issue Mar 15, 2017 · 7 comments
Open

Rethink how we integrate resources in binaries. #31

mgautierfr opened this issue Mar 15, 2017 · 7 comments
Assignees
Milestone

Comments

@mgautierfr
Copy link
Member

We have currently a small solution to embedded resource file in binaries.
The resource file is just store in a C array and the code just read it and interpret it as a file content.

This work well but it could be improved :

  • Some files/resources work together and can be seen as a pack. (stop words list for xapian, all html/css/js for the topbar, ...)
  • It is somehow complicated to allow customization ([kiwix-serve] make the topbar customizable. kiwix-tools#17) or update of the resources. For now the two solutions are either to recompile the binary or use env variables to overwrite the content.

This is somehow a pity as we are a project who embedded different files in a read efficient archive, handling file hierarchy and so. We can probably use our own code base to store and read those resource files :)

@kelson42

This comment has been minimized.

@stale
Copy link

stale bot commented Nov 21, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Nov 21, 2019
@kelson42
Copy link
Collaborator

@mgautierfr What would be a better approach?

@stale stale bot removed the stale label Jan 12, 2022
@stale
Copy link

stale bot commented Mar 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Mar 30, 2022
@kelson42 kelson42 self-assigned this Feb 11, 2023
@kelson42 kelson42 added this to the 12.2.0 milestone Feb 11, 2023
@stale stale bot removed the stale label Feb 11, 2023
@kelson42 kelson42 modified the milestones: 12.2.0, 12.3.0 Feb 12, 2023
@kelson42
Copy link
Collaborator

Why not just using a zip blob? Would be easy to read in c++ and easy to build for anybody whatever the platform. We could then just allow to load an external ZIP fs path tomcustomize things.

@mgautierfr
Copy link
Member Author

At that time, I was thinking about using a zim archive. Now I would use a jubako based container.

@kelson42
Copy link
Collaborator

We won't use anything overkill. Package should better be done via tools people are familiar with. Why is a simple tar or zip not good enough?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants