Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save lines in history file with a Unix timestamp #442

Closed
avinashkanaujiya opened this issue Sep 29, 2020 · 4 comments · Fixed by #604
Closed

Save lines in history file with a Unix timestamp #442

avinashkanaujiya opened this issue Sep 29, 2020 · 4 comments · Fixed by #604
Labels
enhancement

Comments

@avinashkanaujiya
Copy link

Just What I said above...
@gwenn
Copy link
Collaborator

gwenn commented Oct 3, 2020

Maybe we should introduce a Trait like termwiz and provide only a default implementation ?

@walles
Copy link

walles commented Jan 1, 2022

Should this ticket be marked as a duplicate of #127?

With custom history load / save functionality people could add whatever they wanted, and this ticket would be up to the crate users to deal with.

gwenn added a commit to gwenn/rustyline that referenced this issue Feb 23, 2022
@gwenn
[WIP] Introduce History trait
cad603e 
Fix kkawakam#127
Fix kkawakam#442

TODO
- [ ] check if `History::add` and `History::add_owned` can be fused
- [ ] put old / default `FileHistory` behind a feature
- [ ] SQLite based implementation behind a feature
- [ ] timestamped history ? Implementation detail ?
- [ ] editable entry ? later ?

Breaking changes:
* `Editor` impacted (new generic type parameter `I`)
* `History` renamed to `FileHistory`
* History API impacted (to make trait object safe)
@gwenn gwenn mentioned this issue Feb 23, 2022
Merged
5 tasks
@gwenn
Copy link
Collaborator

gwenn commented Feb 23, 2022

2 years later => #604
Feedback is welcome.

@gwenn
Copy link
Collaborator

gwenn commented Feb 19, 2023

Version 11.0.0 released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce History trait gwenn/rustyline
3 participants
@gwenn @walles @avinashkanaujiya