Introduce History trait #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix kkawakam#127 Fix kkawakam#442 TODO - [ ] check if `History::add` and `History::add_owned` can be fused - [ ] put old / default `FileHistory` behind a feature - [ ] SQLite based implementation behind a feature - [ ] timestamped history ? Implementation detail ? - [ ] editable entry ? later ? Breaking changes: * `Editor` impacted (new generic type parameter `I`) * `History` renamed to `FileHistory` * History API impacted (to make trait object safe)
This was referenced Feb 23, 2022
# Conflicts: # Cargo.toml # src/test/mod.rs
Closed
Update History trait accordingly
For SQLite, rowids may not be sequential. So we need to know the direction. And return the matching rowid.
|
If anyone is interested, I would like a code review.
|
# Conflicts: # src/edit.rs # src/lib.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #127
Fix #442
TODO
History::addandHistory::add_ownedcan be fused (https://users.rust-lang.org/t/trait-method-that-supports-both-str-and-string-as-parameter/72498 suggests that this is not possible)FileHistorybehind a featureBreaking changes:
Editorimpacted (new generic type parameterI)Historyrenamed toFileHistory