[CHNL-6170] updated EventName cases in KlaviyoBridge #172
Conversation
* Adopting ios modularization stuff * added a comment to the podfile
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
| :app_path => "#{Pod::Config.instance.installation_root}/.." | ||
| ) | ||
|
|
||
| #TODO: remove this once iOS modularization release is made and the podspec is updated | ||
| pod 'KlaviyoSwift', :path => '../../../klaviyo-swift-sdk/' |
There was a problem hiding this comment.
I think build is failing because of this.
There was a problem hiding this comment.
@ajaysubra @ndurell are we concerned about the failing build at the moment? This change is only temporary so we can work locally until the Swift SDK v4.0.0 is released. Then we revert the changes and CI should build again.
If we want to get CI to pass we can point to the remote git branch rather than the relative path. But then when we're working on it locally we'll probably want to change it back to the relative path
There was a problem hiding this comment.
Uhh do we have to merge with this in? I'd prefer to keep master in a non broken state if possible.
There was a problem hiding this comment.
Yeah you are right. Removed it 🤞🏾
There was a problem hiding this comment.
So the build is still failing. Went on a wild goose chase and found out that even with this line removed the build will fail because the Event name changes in here are not in the release swift version that the podspec is pointing to. Unfortunately, the podspec can't point to a branch of the swift SDK.
2024-09-24T02:50:43.2997240Z ** BUILD FAILED **
2024-09-24T02:50:43.2997360Z
2024-09-24T02:50:43.2997370Z
2024-09-24T02:50:43.2997490Z The following build commands failed:
2024-09-24T02:50:43.2998390Z SwiftCompile normal x86_64 /Users/runner/work/klaviyo-react-native-sdk/klaviyo-react-native-sdk/ios/KlaviyoBridge.swift (in target 'klaviyo-react-native-sdk' from project 'Pods')
2024-09-24T02:50:43.2999890Z SwiftCompile normal x86_64 Compiling\ KlaviyoBridge.swift /Users/runner/work/klaviyo-react-native-sdk/klaviyo-react-native-sdk/ios/KlaviyoBridge.swift (in target 'klaviyo-react-native-sdk' from project 'Pods')
2024-09-24T02:50:43.3000780Z (2 failures)
2024-09-24T02:50:43.3001900Z [ERROR] command finished with error: command (/Users/runner/work/klaviyo-react-native-sdk/klaviyo-react-native-sdk/example) /private/var/folders/4h/j1rdr7ws1cbck70c6bjbk5t40000gn/T/xfs-f23266fe/yarn run build:ios exited (65)
I suggest we keep this line in and merge mainly because we could at least work on this locally and when we release iOS we can get this build passing again. Long term with a WIP swift/android branch we need to figure out how to work.
…thub.com:klaviyo/klaviyo-react-native-sdk into ab/CHNL-6170/update-EventName-cases-in-RN-bridge
…thub.com:klaviyo/klaviyo-react-native-sdk into ab/CHNL-6170/update-EventName-cases-in-RN-bridge
Description
This updates the KlaviyoBridge class to account for the changes made to
EventNameas part of Swift SDK #196Check List