Adopting modularization work #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wiz Scan Summary
|
ajaysubra
commented
Sep 12, 2024
| @@ -0,0 +1,37 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
Just to keep cocoapods happy since it kept complaining about this. We don't really need it since we don't publish this app to TF/public.
| @@ -8,16 +8,6 @@ require Pod::Executable.execute_command('node', ['-p', | |||
| platform :ios, min_ios_version_supported | |||
| prepare_react_native_project! | |||
|
|
|||
| # If you are using a `react-native-flipper` your iOS build will fail when `NO_FLIPPER=1` is set. | |||
| @@ -32,15 +22,11 @@ target 'KlaviyoReactNativeSdkExample' do | |||
|
|
|||
| use_react_native!( | |||
| :path => config[:reactNativePath], | |||
| # Enables Flipper. | |||
There was a problem hiding this comment.
clean up. flipper is no longer supported
ab1470
approved these changes
Sep 13, 2024
ajaysubra
merged commit 67ff804
into
ab/CHNL-6170/update-EventName-cases-in-RN-bridge
4 checks passed
ab1470
added a commit
that referenced
this pull request
Sep 24, 2024
* updated EventName cases in KlaviyoBridge * Adopting modularization work (#173) * Adopting ios modularization stuff * added a comment to the podfile * Update Podfile * updating pod lock * adding new podfile.lock * added back no flipper = 1 * reverted back the pod file changes --------- Co-authored-by: Ajay Subramanya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pulling in the changes made on iOS for modularization. More comments in line.
Check List
Changelog / Code Overview
Test Plan
Related Issues/Tickets