CHNL-12052: Update to include SDK name and version in network requests #175
Conversation
ajaysubra
requested review from
ndurell,
evan-masseau and
ab1470
and removed request for
a team
| <key>react_native_sdk_name</key> | ||
| <string>react_native</string> | ||
| <key>react_native_sdk_version</key> | ||
| <string>9.8.8</string> |
There was a problem hiding this comment.
I think we have a release doc pertaining to RN, lets make sure we update it to mention this is another spot the version needs to get incremented before release
There was a problem hiding this comment.
🤦🏾 I'm glad I used a crazy version for testing. Fixed it to 1.0.0 assuming it's going to be the next release. Good call, I update the confluence doc with this step.
ajaysubra
changed the title
| @@ -13,6 +13,7 @@ Pod::Spec.new do |s| | |||
| s.platforms = { :ios => "13.0" } | |||
| s.source = { :git => "https://github.com/klaviyo/klaviyo-react-native-sdk.git", :tag => "#{s.version}" } | |||
| s.source_files = "ios/**/*.{h,m,mm,swift}" | |||
| s.resources = ["ios/klaviyo-react-native-sdk-configuration.plist"] | |||
There was a problem hiding this comment.
There is no spm equivalent of this or that's not needed right?
There was a problem hiding this comment.
Hmm, didn't think about SPM. I think since we are including KlaviyoSwift SDK in the podspec and also since RN only supports cocoapods we should be good. Also, there is no package file in RN, there is no way to add this plist as a resource.
ios/KlaviyoBridge.swift
Outdated
| "VIEWED_PRODUCT": Event.EventName.viewedProductMetric.value, | ||
| "STARTED_CHECKOUT": Event.EventName.startedCheckoutMetric.value, | ||
| "OPENED_APP": Event.EventName.openedAppMetric.value, | ||
| "ADDED_TO_CART": Event.EventName.addedToCartMetric.value |
ajaysubra
deleted the
as/chnl-12052-update-to-send-sdk-name-and-version
branch
Description
Does two things,
klaviyo-react-native-sdk-configuration.plistto the iOS directory.Slightly unrelated but updated the breaking changes from the swift SDK and pushing them as well. FYI @ab1470
Test Plan
Tested locally by pulling in local version of Swift SDK and using the internal test app.