-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHNL-12052: Update to include SDK name and version in network requests #175
Changes from 7 commits
c2fb566
f98d30e
e9caa17
8d28822
b434821
84f4e57
483032f
5a2bb82
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | ||
<!-- | ||
config.plist | ||
Pods | ||
|
||
Created by Ajay Subramanya on 9/18/24. | ||
Copyright (c) 2024 Klaviyo. All rights reserved. | ||
|
||
DO NOT MODIFY THE KEYS IN THIS FILE. THEY ARE REFERENCED BY THE iOS SDK | ||
--> | ||
<plist version="1.0"> | ||
<dict> | ||
<key>react_native_sdk_name</key> | ||
<string>react_native</string> | ||
<key>react_native_sdk_version</key> | ||
<string>1.0.0</string> | ||
</dict> | ||
</plist> |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,6 +13,7 @@ Pod::Spec.new do |s| | |
s.platforms = { :ios => "13.0" } | ||
s.source = { :git => "https://github.com/klaviyo/klaviyo-react-native-sdk.git", :tag => "#{s.version}" } | ||
s.source_files = "ios/**/*.{h,m,mm,swift}" | ||
s.resources = ["ios/klaviyo-react-native-sdk-configuration.plist"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is no spm equivalent of this or that's not needed right? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm, didn't think about SPM. I think since we are including |
||
|
||
s.pod_target_xcconfig = { "DEFINES_MODULE" => "YES" } | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! 🙏🏻