Propagate ClusterConfiguration in kind correctly #3265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
the
size/XS
knative-prow
bot
added
the
approved
Codecov Report
@@ Coverage Diff @@
## main #3265 +/- ##
============================================
+ Coverage 61.87% 61.89% +0.01%
- Complexity 764 765 +1
============================================
Files 181 181
Lines 12200 12200
Branches 268 268
============================================
+ Hits 7549 7551 +2
+ Misses 4062 4061 -1
+ Partials 589 588 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
@aliok could you PTAL at this PR? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
knative-prow
bot
merged commit 60d3d6d
into
knative-extensions:main
16 of 18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During knative/eventing#7140 I saw, that the ClusterConfiguration is not used correctly (e.g. the cluster domain not set correctly). This is due to an old apiVersion field, which (according to kubernetes-sigs/kind#1466 (comment)) can be dropped.
Also the
metadata.namefield can be dropped (kind docu: kubeadm-config-patches).With this fix, configs, like the CLUSTER_SUFFIX will be propagated correctly to kubeadm again.