-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate ClusterConfiguration in kind correctly #3265
Propagate ClusterConfiguration in kind correctly #3265
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3265 +/- ##
============================================
+ Coverage 61.87% 61.89% +0.01%
- Complexity 764 765 +1
============================================
Files 181 181
Lines 12200 12200
Branches 268 268
============================================
+ Hits 7549 7551 +2
+ Misses 4062 4061 -1
+ Partials 589 588 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
@aliok could you PTAL at this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
60d3d6d
into
knative-extensions:main
During knative/eventing#7140 I saw, that the ClusterConfiguration is not used correctly (e.g. the cluster domain not set correctly). This is due to an old apiVersion field, which (according to kubernetes-sigs/kind#1466 (comment)) can be dropped.
Also the
metadata.name
field can be dropped (kind docu: kubeadm-config-patches).With this fix, configs, like the CLUSTER_SUFFIX will be propagated correctly to kubeadm again.