-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use correct cluster domain in e2e tests #7140
Use correct cluster domain in e2e tests #7140
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #7140 +/- ##
==========================================
+ Coverage 77.93% 77.94% +0.01%
==========================================
Files 248 248
Lines 13332 13257 -75
==========================================
- Hits 10390 10333 -57
+ Misses 2408 2398 -10
+ Partials 534 526 -8 ☔ View full report in Codecov by Sentry. |
/hold |
Supporting this kind of testing is more involved, especially with TLS where certificates have specific DNS names |
Just as FYI: Seems we have the kind e2e/rekt failures since the k8s version bump to 1.25: 2899fce (56e9ee1 merged before and the tests still passed). From commit history: https://github.com/knative/eventing/commits/main?after=3915df7f856089af51860c43a73a12f8462c0ceb+259&branch=main&qualified_name=refs%2Fheads%2Fmain |
Acccording to kubernetes-sigs/kind#1466 (comment) it is not needed anymore to specify the apiVersion of the ClusterConfiguration. This also fixes that the config is propagated to kubeadm correctly.
07a9fbc
to
622bc11
Compare
/unhold |
/test upgrade-tests |
1 similar comment
/test upgrade-tests |
/assign @pierDipi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Currently some e2e tests running on kind are failing due to errors like:
expecting extension 'knativeerrordest' equal to 'http://failer-witdata-nprfdmbb.test-bepfnesy.svc.c5728157394.local', got 'http://failer-witdata-nprfdmbb.test-bepfnesy.svc.cluster.local'
This is, because some tests assume a cluster domain of
cluster.local
, while we set them for the e2e tests on kind:eventing/.github/workflows/kind-e2e.yaml
Lines 115 to 120 in 8a09756
eventing/.github/workflows/kind-e2e.yaml
Lines 46 to 55 in 8a09756
This PR addresses it and gets the cluster domain from the
CLUSTER_DOMAIN
env./assign @pierDipi @matzew