Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: Running serving or eventing specific e2e is broken #828

Closed
navidshaikh opened this issue May 6, 2020 · 1 comment · Fixed by #832
Closed

e2e: Running serving or eventing specific e2e is broken #828

navidshaikh opened this issue May 6, 2020 · 1 comment · Fixed by #832
Assignees
@navidshaikh
Labels
good first issue Denotes an issue ready for a new contributor. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Milestone
v0.15.0

Comments

@navidshaikh
Copy link
Collaborator

navidshaikh commented May 6, 2020 •
edited
Loading

Bug report

Unable to run serving or eventing specific e2e tests using tags.

Expected behavior

A user should be able to run only eventing or serving specific e2e tests.

Steps to reproduce the problem

go test -mod=vendor ./test/e2e/ -test.v -tags "e2e serving" 

# knative.dev/client/test/e2e [knative.dev/client/test/e2e.test]
test/e2e/sinkprefix_test.go:81:14: undefined: getResourceFieldsWithJSONPath
test/e2e/sinkprefix_test.go:86:2: undefined: pingSourceDelete
FAIL	knative.dev/client/test/e2e [build failed]
FAIL

OR

go test -mod=vendor ./test/e2e/ -test.v -tags "e2e eventing" .

# knative.dev/client/test/e2e [knative.dev/client/test/e2e.test]
test/e2e/ping_test.go:41:2: undefined: serviceCreate
test/e2e/ping_test.go:56:2: undefined: serviceCreate
test/e2e/sinkprefix_test.go:76:2: undefined: serviceCreate
test/e2e/source_apiserver_test.go:54:2: undefined: serviceCreate
test/e2e/source_apiserver_test.go:80:2: undefined: serviceCreate
test/e2e/source_binding_test.go:40:2: undefined: serviceCreate
test/e2e/source_binding_test.go:51:2: undefined: serviceCreate
test/e2e/trigger_inject_broker_test.go:42:2: undefined: serviceCreate
test/e2e/trigger_inject_broker_test.go:43:2: undefined: serviceCreate
test/e2e/trigger_test.go:47:2: undefined: serviceCreate
test/e2e/trigger_test.go:47:2: too many errors
FAIL	knative.dev/client/test/e2e [build failed]
FAIL

kn version

HEAD/master

➜  ./kn version
Version:      v20200506-local-9774d070
Build Date:   2020-05-06 11:20:39
Git Revision: 9774d070
Supported APIs:
* Serving
  - serving.knative.dev/v1 (knative-serving v0.14.0)
* Eventing
  - sources.knative.dev/v1alpha2 (knative-eventing v0.14.1)
  - eventing.knative.dev/v1alpha1 (knative-eventing v0.14.1)

/kind good-first-issue
/kind cleanup
@navidshaikh navidshaikh added the kind/bug Categorizes issue or PR as related to a bug. label May 6, 2020
@knative-prow-robot knative-prow-robot added good first issue Denotes an issue ready for a new contributor. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels May 6, 2020
@navidshaikh
Copy link
Collaborator Author

/assign

@navidshaikh navidshaikh mentioned this issue May 8, 2020
Merged
@navidshaikh navidshaikh added this to the v0.15.0 milestone May 14, 2020
coryrc pushed a commit to coryrc/client that referenced this issue May 14, 2020
@chizhg @knative-prow-robot
Fix the logic to find the latest release build for the given repo (kn…
fbe5f9e 
…ative#828)

* find the nearest available tag for the given branch

* fix CR issues

* add quotes for vars

* fix PR issues

* fix CR issues

* fix CR issue
dsimansk pushed a commit to dsimansk/client that referenced this issue Oct 7, 2021
@mgencur
Tekton - use ClusterRoleBinding v1 (knative#1440) (knative#828)
b4fa2e8 
* Tekton test - ClusterRoleBinding v1

* make it compatible with Kubernetes 1.22

* TMP: Test Tekton in presubmits

* Revert "TMP: Test Tekton in presubmits"

This reverts commit 8996ac7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@navidshaikh navidshaikh

Labels
good first issue Denotes an issue ready for a new contributor. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging a pull request may close this issue.

fix(e2e): Refactor e2e utils and resource actions navidshaikh/client
2 participants
@navidshaikh @knative-prow-robot