Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(e2e): Refactor e2e utils and resource actions #832

Merged
merged 3 commits into from
May 11, 2020
Merged

fix(e2e): Refactor e2e utils and resource actions #832

merged 3 commits into from
May 11, 2020

Conversation

navidshaikh
Copy link
Collaborator

@navidshaikh navidshaikh commented May 8, 2020 •
edited
Loading

Description

brings commonly re-used utilities into lib/test so they can be resused
and e2e can be run selectively for eventing/serving.

Fixes #828

@navidshaikh
fix(e2e): Refactor e2e utils and resource actions
79deb7b 
 brings commonly re-used utilities into lib/test so they can be resused
 and e2e can be run selectively for eventing/serving.
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 8, 2020
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 8, 2020
@navidshaikh
Copy link
Collaborator Author

navidshaikh commented May 8, 2020 •
edited
Loading

/hold
would like to separate out more such utils which are defined in tests, so they can be re-used in -contrib as well

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 8, 2020
@knative-prow-robot knative-prow-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 8, 2020
@navidshaikh
Copy link
Collaborator Author

/unhold

refactored service and revision e2e test utils into test libs

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 8, 2020
@navidshaikh
Copy link
Collaborator Author

selective local e2e test run works fine now

➜  client git:(pr/fix-828) go test -mod=vendor ./test/e2e/ -test.v -tags "e2e eventing"  

=== RUN   TestSourcePing
=== PAUSE TestSourcePing
[..]

➜  client git:(pr/fix-828) go test -mod=vendor ./test/e2e/ -test.v -tags "e2e serving"  

=== RUN   TestBasicWorkflow
=== PAUSE TestBasicWorkflow
[..]

maximilien
maximilien approved these changes May 8, 2020
View reviewed changes
Copy link
Contributor

@maximilien maximilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Like it. One minor comment is whether it would make sense to add godoc comments to the public functions in lib/test? Especially since these are expressly intended to be reused for plugins and external teams. Some of the functions are pretty straightforward so just simple comment and perhaps explanation for the params, especially when there are many or non-obvious.

Otherwise LGTM

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maximilien, navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [maximilien,navidshaikh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@navidshaikh
Copy link
Collaborator Author

/lint

@maximilien : added docstrings, thanks!

knative-prow-robot
knative-prow-robot reviewed May 8, 2020
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@navidshaikh: 0 warnings.

In response to this:

/lint

@maximilien : added docstrings, thanks!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@navidshaikh navidshaikh mentioned this pull request May 8, 2020
Closed
@dsimansk
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2020
@knative-prow-robot knative-prow-robot merged commit e05c334 into knative:master May 11, 2020
@navidshaikh navidshaikh deleted the pr/fix-828 branch May 11, 2020 14:20
@navidshaikh navidshaikh modified the milestone: v0.15.0 May 14, 2020
coryrc pushed a commit to coryrc/client that referenced this pull request May 14, 2020
@chaodaiG @knative-prow-robot
Move ghutil to under shared (knative#832)
beeb630
@navidshaikh navidshaikh added this to the v0.15.0 milestone May 27, 2020
rhuss added a commit to rhuss/knative-client that referenced this pull request Mar 9, 2021
@rhuss
Add David as approver
d88920a 
David meets all criteria for an approver:

- [x] Reviewer for at least 3 months
- [x] Primary reviewer for at least 10 substantial PRs to the codebase, e.g.
  * knative#1246
  * knative#1194
  * knative#738
  * knative#832
  * knative#1016
  * knative#877
  * knative#667
  * knative#697
  * knative#1212
  * knative#835
- [x] Reviewed at least 30 PRs to the codebase ([38 assigned PRs](https://github.com/knative/client/pulls?q=type%3Apr+assignee%3Adsimansk+))
- [x] Nominated by a WG lead (rhuss)

Congrats David ! Thanks a lot for your awesome work & contributions.
@rhuss rhuss mentioned this pull request Mar 9, 2021
Merged
4 tasks
rhuss added a commit to rhuss/knative-client that referenced this pull request Mar 9, 2021
@rhuss
Add David as approver
f266fca 
David meets all criteria for an approver:

- [x] Reviewer for at least 3 months
- [x] Primary reviewer for at least 10 substantial PRs to the codebase, e.g.
  * knative#1246
  * knative#1194
  * knative#738
  * knative#832
  * knative#1016
  * knative#877
  * knative#667
  * knative#697
  * knative#1212
  * knative#835
- [x] Reviewed at least 30 PRs to the codebase ([38 assigned PRs](https://github.com/knative/client/pulls?q=type%3Apr+assignee%3Adsimansk+))
- [x] Nominated by a WG lead (rhuss)

Congrats David ! Thanks a lot for your awesome work & contributions.
knative-prow-robot pushed a commit that referenced this pull request Mar 9, 2021
@rhuss
Add David as approver (#1255)
9fa8d6b 
David meets all criteria for an approver:

- [x] Reviewer for at least 3 months
- [x] Primary reviewer for at least 10 substantial PRs to the codebase, e.g.
  * #1246
  * #1194
  * #738
  * #832
  * #1016
  * #877
  * #667
  * #697
  * #1212
  * #835
- [x] Reviewed at least 30 PRs to the codebase ([38 assigned PRs](https://github.com/knative/client/pulls?q=type%3Apr+assignee%3Adsimansk+))
- [x] Nominated by a WG lead (rhuss)

Congrats David ! Thanks a lot for your awesome work & contributions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@maximilien maximilien maximilien approved these changes

@evankanderson evankanderson Awaiting requested review from evankanderson

Assignees

@dsimansk dsimansk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging this pull request may close these issues.

e2e: Running serving or eventing specific e2e is broken
5 participants
@navidshaikh @knative-prow-robot @dsimansk @maximilien @googlebot