Pr/release 0.13.2 backports #806

rhuss · 2020-04-15T08:54:15Z

Description

Backport of critical fixes from master:

…native#765) * (refactor) address the e2e extract / refactor of issue knative#763 * various updates to address reviewers feedback * renamed lib/test/integration to lib/test and package to test Signed-off-by: Roland Huß <[email protected]> # Conflicts: # CHANGELOG.adoc # test/e2e/service_export_import_apply_test.go # test/e2e/trigger_test.go

* fix(plugin): Fix plugin lookup with file ext on Windows * chore: Update changelog * fix: Reflect review feedback * fix: Reflect review feedback and add future todo Signed-off-by: Roland Huß <[email protected]> # Conflicts: # CHANGELOG.adoc

…native#778) * fix(issue knative#762): correct error message when updating service * correct message when updating service and passing many names * fix issue with TestServiceUpdateWithMultipleImages running create vs update * * added TestServiceDescribeWithMultipleNames * added TestServiceCreateWithMultipleNames * fix error message for service delete since many names can be passed

Also set GO111MODULE=on unconditionally

…tilizationPercentage" annotation (knative#788) * Support setting "autoscaling.knative.dev/targetUtilizationPercentage" annotation. Signed-off-by: Roland Huß <[email protected]> # Conflicts: # test/e2e/service_options_test.go

* Remove the delete propagation flag In it's current state it now takes me about 25 seconds for the `kn delete` to complete. Before knative#682 it used to be almost immediate. This is because we now pass in the `DeletePropagationBackground` flag. I believe this is a mistake, not only because of the 20+ seconds of additional time to delete things, but IMO the CLI should talk to the server in the same way regardless of the --wait flag. That flag should just be a CLI thing to indicate if the user wants the CLI to wait for the server to complete but not HOW the server should do the delete. Signed-off-by: Doug Davis <[email protected]> * try just tweaking the --no-wait flag Signed-off-by: Doug Davis <[email protected]>

* fix error when output is set to name * add e2e test * change to flags/listprint.go Signed-off-by: Roland Huß <[email protected]> # Conflicts: # test/e2e/basic_workflow_test.go

* The `kn service describe -v` command shows repetitive revisions, because the revision would be covered by next one.

* Fix resource listing with -oname flag * add e2e tests Signed-off-by: Roland Huß <[email protected]> # Conflicts: # test/e2e/ping_test.go # test/e2e/revision_test.go # test/e2e/route_test.go # test/e2e/source_apiserver_test.go # test/e2e/source_binding_test.go # test/e2e/trigger_test.go

…ve#802) * Make wait, no-wait and async flags per bool var CLI convention Fixes knative#800 - Deprecated bool vars can be supported for CLI convention - Bind --async flag value to --no-wait - Only one flag among [wait, no-wait, async] can be provided, else raise an error * Simplify conditionals * Add unit tests for deprecated flag async * Fix a typo

* e2e: Foreground delete for revisions and services in e2e to avoid any race conditions and flakes * Use --wait instead of --no-wait=false Signed-off-by: Roland Huß <[email protected]> # Conflicts: # test/e2e/basic_workflow_test.go # test/e2e/revision_test.go

* Use buildah task from master branch and paramterize FORMAT * Configure pipeline v0.11.1 * DNM: Run tekton e2e in this PR * Revert "DNM: Run tekton e2e in this PR" This reverts commit 903f5be.

* Pin serving v0.13.2 dep to v0.13.2 * Update version command now points to serving v0.13.2 and eventing v0.13.6 * Copy go.sum as generated in CI Signed-off-by: Roland Huß <[email protected]> # Conflicts: # go.mod # go.sum # vendor/modules.txt

googlebot · 2020-04-15T08:54:32Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

googlebot · 2020-04-15T08:57:47Z

☹️ Sorry, but only Googlers may change the label cla: yes.

rhuss · 2020-04-15T09:06:12Z

@googlebot I consent.

mattmoor

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)

test/e2e/service_export_import_apply_test.go

* e2e for service export * e2e for service export * e2e for service export * e2e for service export * e2e for service export Signed-off-by: Roland Huß <[email protected]> # Conflicts: # test/e2e/service_export_import_apply_test.go

knative-metrics-robot · 2020-04-15T13:08:30Z

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/serving/config_changes.go	79.6%	79.7%	0.1

navidshaikh · 2020-04-15T14:22:54Z

@googlebot I consent.

dsimansk · 2020-04-15T14:26:26Z

@googlebot I consent.

navidshaikh

/lgtm

knative-prow-robot · 2020-04-15T14:55:00Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: navidshaikh, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [navidshaikh,rhuss]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

googlebot · 2020-04-15T16:04:58Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

maximilien and others added 15 commits April 15, 2020 10:03

Use vendored deps while running e2e locally (knative#783)

f521cc3

Also set GO111MODULE=on unconditionally

Update sink binding create usage string (knative#785)

f94a787

Fix error when output is set to name (knative#775)

5feaed3

* fix error when output is set to name * add e2e test * change to flags/listprint.go Signed-off-by: Roland Huß <[email protected]> # Conflicts: # test/e2e/basic_workflow_test.go

Show all revisions when run service describe -v (knative#790)

6843871

* The `kn service describe -v` command shows repetitive revisions, because the revision would be covered by next one.

e2e: Run tekton e2e against pipeline v0.11.1 (knative#803)

34c225e

* Use buildah task from master branch and paramterize FORMAT * Configure pipeline v0.11.1 * DNM: Run tekton e2e in this PR * Revert "DNM: Run tekton e2e in this PR" This reverts commit 903f5be.

Update CHANGELOG for v0.13.2 (knative#804)

036796f

knative-prow-robot requested review from cppforlife and evankanderson April 15, 2020 08:54

knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 15, 2020

googlebot added the cla: no Indicates the PR's author has not signed the CLA. label Apr 15, 2020

rhuss added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Apr 15, 2020

googlebot removed the cla: yes Indicates the PR's author has signed the CLA. label Apr 15, 2020

add missing vendored files

4fe7472

googlebot added the cla: no Indicates the PR's author has not signed the CLA. label Apr 15, 2020

rhuss added 2 commits April 15, 2020 12:17

fixed error reporting for traffics tests

910c860

Updated test

5fb3c8d

mattmoor reviewed Apr 15, 2020

View reviewed changes

test/e2e/service_export_import_apply_test.go Outdated Show resolved Hide resolved

rhuss and others added 2 commits April 15, 2020 14:42

fix formatting

c0d2832

e2e for service export (knative#739)

bda69ba

* e2e for service export * e2e for service export * e2e for service export * e2e for service export * e2e for service export Signed-off-by: Roland Huß <[email protected]> # Conflicts: # test/e2e/service_export_import_apply_test.go

navidshaikh approved these changes Apr 15, 2020

View reviewed changes

knative-prow-robot assigned navidshaikh Apr 15, 2020

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2020

isdal added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Apr 15, 2020

knative-prow-robot merged commit b67f302 into knative:release-0.13 Apr 15, 2020

rhuss added the backport/pr A backport PR which is target to a release branch. label Apr 20, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pr/release 0.13.2 backports #806

Pr/release 0.13.2 backports #806

rhuss commented Apr 15, 2020

googlebot commented Apr 15, 2020

googlebot commented Apr 15, 2020

rhuss commented Apr 15, 2020

mattmoor left a comment

knative-metrics-robot commented Apr 15, 2020

navidshaikh commented Apr 15, 2020

dsimansk commented Apr 15, 2020

navidshaikh left a comment

knative-prow-robot commented Apr 15, 2020

googlebot commented Apr 15, 2020

Pr/release 0.13.2 backports #806

Pr/release 0.13.2 backports #806

Conversation

rhuss commented Apr 15, 2020

Description

googlebot commented Apr 15, 2020

googlebot commented Apr 15, 2020

rhuss commented Apr 15, 2020

mattmoor left a comment

Choose a reason for hiding this comment

knative-metrics-robot commented Apr 15, 2020

navidshaikh commented Apr 15, 2020

dsimansk commented Apr 15, 2020

navidshaikh left a comment

Choose a reason for hiding this comment

knative-prow-robot commented Apr 15, 2020

googlebot commented Apr 15, 2020