-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document Client CLI kn domain #3496
Comments
Is this something I could actively drive or is it more about delivering input for the documentation and the docs creation happens by somebody else ? Happy to do either, if I know where to put this documentation to. |
Note to self: Related to knative/ux#39 |
@rhuss either is fine - do you have draft info for docs for this, or want to take this issue and add a PR yourself? |
Let me pick this issue and write a documentation PR. |
/priority high |
Bump @rhuss - any progress on this one? Thanks! |
@abrennan89 thanks for the reminder. I know you will be angry with me 🙇 :) , but could you give me a quick pointer where to add the PR for the documentation ? (I mean to which file) . Thanks and apologies to bug you with this question, but the location is probably not https://knative.dev/docs/client/ ? |
lol I'm not angry, don't worry 😄 thanks for getting back to me! |
@abrennan89 to which source file does https://knative.dev/docs/developer/serving/services/custom-domains/ translate ? I can't find it in the docs repo. There I only can find https://github.com/knative/docs/blob/mkdocs/docs/serving/using-a-custom-domain.md which is a completely different document. |
@rhuss are you sure you're on the correct branch in git and that you have pulled / rebased any changes from upstream? I just checked on my local repo and it's definitely under docs/docs/developer/serving/services/custom-domains.md |
It's because it just hasn't been moved over yet, the plan was to use mkdocs temporarily. |
The new version of the
kn
CLI container a new commanddomain
The info is included in the release notes but it should properly be documented in the website
It was suggested by @abrennan89 to open an issue in the PR for the release notes blod here
/assign @rhuss
The text was updated successfully, but these errors were encountered: