blog post for knative release 0.22 #3486
Conversation
knative-prow-robot
added
the
size/L
|
/assign |
|
|
||
| ### Highlights | ||
|
|
||
| - Serving Domain Mapping improves multi-tenency support to avoid domain name 'squatting' in cluster. |
There was a problem hiding this comment.
| - Serving Domain Mapping improves multi-tenency support to avoid domain name 'squatting' in cluster. | |
| - Serving Domain Mapping improves multi-tenancy support to avoid domain name 'squatting' in the cluster. |
|
|
||
| - Serving Domain Mapping improves multi-tenency support to avoid domain name 'squatting' in cluster. | ||
| - Eventing now allows Trigger users to set another namespace's Subscriber | ||
| - Eventing kafka broker now Kubernetes's minimum version is 1.18 |
There was a problem hiding this comment.
I don't understand this sentence. Maybe because of my lack of understanding of Eventing.
|
|
||
| - Serving Domain Mapping improves multi-tenency support to avoid domain name 'squatting' in cluster. | ||
| - Eventing now allows Trigger users to set another namespace's Subscriber | ||
| - Eventing kafka broker now Kubernetes's minimum version is 1.18 |
There was a problem hiding this comment.
| - Eventing kafka broker now Kubernetes's minimum version is 1.18 | |
| - Eventing Kafka broker now Kubernetes's minimum version is 1.18 |
| - Serving Domain Mapping improves multi-tenency support to avoid domain name 'squatting' in cluster. | ||
| - Eventing now allows Trigger users to set another namespace's Subscriber | ||
| - Eventing kafka broker now Kubernetes's minimum version is 1.18 | ||
| - Eventing kafka now supports the ability to choose between ordered and unordered delivery |
There was a problem hiding this comment.
| - Eventing kafka now supports the ability to choose between ordered and unordered delivery | |
| - Eventing Kafka now supports the ability to choose between ordered and unordered delivery |
There was a problem hiding this comment.
Use Apache Kafka everywhere, or just "Kafka with Knative Eventing"?
There was a problem hiding this comment.
Also, be consistent about using periods / full stops at the end of sentences 😉
| - Eventing kafka broker now Kubernetes's minimum version is 1.18 | ||
| - Eventing kafka now supports the ability to choose between ordered and unordered delivery | ||
| - The CLI `kn` 0.22.0 comes with some bug fixes and minor feature enhancements. It's mostly a polishing release. If you are using the client API, there is a breaking change that was needed to align with Kubernetes client API's | ||
| - There are two new CLI plugins align with 0.22 release, [kn-plugin-admin](https://github.com/knative-sandbox/kn-plugin-admin) and [kn-plugin-source-kafka](https://github.com/knative-sandbox/kn-plugin-source-kafka) |
There was a problem hiding this comment.
| - There are two new CLI plugins align with 0.22 release, [kn-plugin-admin](https://github.com/knative-sandbox/kn-plugin-admin) and [kn-plugin-source-kafka](https://github.com/knative-sandbox/kn-plugin-source-kafka) | |
| - There are two new CLI plugins to align with the 0.22 release, [kn-plugin-admin](https://github.com/knative-sandbox/kn-plugin-admin) and [kn-plugin-source-kafka](https://github.com/knative-sandbox/kn-plugin-source-kafka) |
| - Eventing kafka now supports the ability to choose between ordered and unordered delivery | ||
| - The CLI `kn` 0.22.0 comes with some bug fixes and minor feature enhancements. It's mostly a polishing release. If you are using the client API, there is a breaking change that was needed to align with Kubernetes client API's | ||
| - There are two new CLI plugins align with 0.22 release, [kn-plugin-admin](https://github.com/knative-sandbox/kn-plugin-admin) and [kn-plugin-source-kafka](https://github.com/knative-sandbox/kn-plugin-source-kafka) | ||
| - The Knative Operator release with some bug fixes, and supports the latest version of knative serving and eventing. |
There was a problem hiding this comment.
| - The Knative Operator release with some bug fixes, and supports the latest version of knative serving and eventing. | |
| - The Knative Operator was released with some bug fixes and supports the latest version of Knative Serving and Eventing. |
| - Bumped the resource request and limits of the autoscaler to 100m/100Mi, 1000m/1000Mi respectively. [#10865](https://github.com/knative/serving/pull/10865) | ||
| - Fixed a regression where the pod bringup time might have a latency of 10s or more even though the container should be up quickly. [#10992](https://github.com/knative/serving/pull/10992) | ||
| - Reduced the necessary memory allocations in the activator significantly, especially with disabled tracing. [#11016](https://github.com/knative/serving/pull/11016), [#11013](https://github.com/knative/serving/pull/11013), [#11009](https://github.com/knative/serving/pull/11009), [#11008](https://github.com/knative/serving/pull/11008) | ||
| - Fix the incorrect Gateway name format for DomainMapping auto TLS feature for net-istio implmenetation. [net-istio#532](https://github.com/knative-sandbox/net-istio/pull/532) |
There was a problem hiding this comment.
| - Fix the incorrect Gateway name format for DomainMapping auto TLS feature for net-istio implmenetation. [net-istio#532](https://github.com/knative-sandbox/net-istio/pull/532) | |
| - Fixed the incorrect Gateway name format for DomainMapping auto TLS feature for net-istio implementation. [net-istio#532](https://github.com/knative-sandbox/net-istio/pull/532) |
|
|
||
| #### 🐞 Bug Fixes | ||
|
|
||
| - Adds validation that a default max-scale is set if a max-scale-limit is specified in the autoscaler configmap (since otherwise the default max-scale, i.e. 0 = no max, would fail validation as it is above the max-scale-limit). [#10921](https://github.com/knative/serving/pull/10921) |
There was a problem hiding this comment.
| - Adds validation that a default max-scale is set if a max-scale-limit is specified in the autoscaler configmap (since otherwise the default max-scale, i.e. 0 = no max, would fail validation as it is above the max-scale-limit). [#10921](https://github.com/knative/serving/pull/10921) | |
| - Added validation that a default max-scale is set if a max-scale-limit is specified in the autoscaler configmap (since otherwise the default max-scale, i.e. 0 = no max, would fail validation as it is above the max-scale-limit). [#10921](https://github.com/knative/serving/pull/10921) |
| #### 🚨 API Changes | ||
|
|
||
| - v1alpha1 Channel duck types are no longer supported. [#5005](https://github.com/knative/eventing/pull/5005) | ||
| - Allow Trigger users to set another namespace's Subscriber, And when Subscriber's namespace not been set, it will be set to Trigger's namespace [#4995](https://github.com/knative/eventing/pull/4995) |
There was a problem hiding this comment.
| - Allow Trigger users to set another namespace's Subscriber, And when Subscriber's namespace not been set, it will be set to Trigger's namespace [#4995](https://github.com/knative/eventing/pull/4995) | |
| - Allow Trigger users to set another namespace's Subscriber. When Subscriber's namespace is not set, it will be set to Trigger's namespace [#4995](https://github.com/knative/eventing/pull/4995) |
|
|
||
| #### 🧹 Clean up | ||
|
|
||
| - Do not set the finalizer for pingSource for pingSource controller, just deal with it in reconcilekind [#5002](https://github.com/knative/eventing/pull/5002) |
There was a problem hiding this comment.
| - Do not set the finalizer for pingSource for pingSource controller, just deal with it in reconcilekind [#5002](https://github.com/knative/eventing/pull/5002) | |
| - Do not set the finalizer for pingSource, for pingSource controller. Just deal with it in reconcilekind [#5002](https://github.com/knative/eventing/pull/5002) |
There was a problem hiding this comment.
Be consistent with PingSource formatting.
@omerbensaadon this is part of the API object formatting issue for the style guide; we need to make a decision on that ASAP so that folks have some guidance.
There was a problem hiding this comment.
If you make the decision on this, I will document it :D
There was a problem hiding this comment.
CC: @RichardJJG @snneji who are also qualified to make a decision on this
|
/hold I will make the changes. I prefer to click the button to accept suggested changes, but then it is a pain to deal with the Google CLA with multiple authors. |
knative-prow-robot
added
the
do-not-merge/hold
|
@csantanapr when it's all ready Grant should be able to manually fix the CLA if it's a problem, probably faster to do that than for you to have to manually do the suggestions 🙂 |
| title: "Version v0.22 release" | ||
| linkTitle: "Version v0.22 release" |
There was a problem hiding this comment.
Do we need "Version" and "v" in the title?
There was a problem hiding this comment.
I will remove the small v
|
@abrennan89 Im already aware that reaching to anyone from the Google company can fix the CLA problem. But I choose to not go thru that route and that this problem is a that I consider very bad taste for open source. I don't want to project or give the impression that I'm fine with it by using the workaround on waiting for a person from specific company. I know is not any individual fault and part on Github UI. But something must be done I hope it gets fix with some better automation on dealing with authors and CLA. |
|
|
||
| ### Highlights | ||
|
|
||
| - Serving Domain Mapping improves multi-tenency support to avoid domain name 'squatting' in cluster. |
There was a problem hiding this comment.
Don't use 'squatting' here; explain properly what it means
| ### Highlights | ||
|
|
||
| - Serving Domain Mapping improves multi-tenency support to avoid domain name 'squatting' in cluster. | ||
| - Eventing now allows Trigger users to set another namespace's Subscriber |
There was a problem hiding this comment.
| - Eventing now allows Trigger users to set another namespace's Subscriber | |
| - Eventing now allows subscribers and triggers from different namespaces to be used together. |
Not totally sure if this is right or what this means otherwise, it seems like you're saying triggers can have subscribers that are in a different namespace to them now?
|
|
||
| - Serving Domain Mapping improves multi-tenency support to avoid domain name 'squatting' in cluster. | ||
| - Eventing now allows Trigger users to set another namespace's Subscriber | ||
| - Eventing kafka broker now Kubernetes's minimum version is 1.18 |
There was a problem hiding this comment.
| - Eventing kafka broker now Kubernetes's minimum version is 1.18 | |
| - 1.18 is now the minimum Kubernetes version required to use the Apache Kafka broker with Knative Eventing v0.22. |
| - The CLI `kn` 0.22.0 comes with some bug fixes and minor feature enhancements. It's mostly a polishing release. If you are using the client API, there is a breaking change that was needed to align with Kubernetes client API's | ||
| - There are two new CLI plugins align with 0.22 release, [kn-plugin-admin](https://github.com/knative-sandbox/kn-plugin-admin) and [kn-plugin-source-kafka](https://github.com/knative-sandbox/kn-plugin-source-kafka) |
There was a problem hiding this comment.
| - The CLI `kn` 0.22.0 comes with some bug fixes and minor feature enhancements. It's mostly a polishing release. If you are using the client API, there is a breaking change that was needed to align with Kubernetes client API's | |
| - There are two new CLI plugins align with 0.22 release, [kn-plugin-admin](https://github.com/knative-sandbox/kn-plugin-admin) and [kn-plugin-source-kafka](https://github.com/knative-sandbox/kn-plugin-source-kafka) | |
| - Version 0.22 of the `kn` CLI contains bug fixes and minor feature enhancements. | |
| - A breaking change was required to align the client API with the Kubernetes client API. | |
| - There are two new CLI plugins available in version 0.22; [kn-plugin-admin](https://github.com/knative-sandbox/kn-plugin-admin) and [kn-plugin-source-kafka](https://github.com/knative-sandbox/kn-plugin-source-kafka). |
There was a problem hiding this comment.
@omerbensaadon @snneji @RichardJJG can we choose one way to consistently refer to "version" across docs and Knative in general? Do you have any preference? I don't want to keep using "version 0.22" in some places and "v0.22" in others for example if we can help it. Can you maybe take this to the TOC, Omer?
There was a problem hiding this comment.
My opinion is that deciding to use 0.22 vs. v0.22 in the website/docs, is something that the docs/ux team can make the decision and document that this is the style across the website.
I added the question in the new doc that @omerbensaadon started https://docs.google.com/document/d/1tigolRzKhronvgoAJfszE-XHWWd0LQ8o_j0D73O9KvM/edit
There was a problem hiding this comment.
I'm making everything consistent for now to use v0.22
| - Eventing kafka now supports the ability to choose between ordered and unordered delivery | ||
| - The CLI `kn` 0.22.0 comes with some bug fixes and minor feature enhancements. It's mostly a polishing release. If you are using the client API, there is a breaking change that was needed to align with Kubernetes client API's | ||
| - There are two new CLI plugins align with 0.22 release, [kn-plugin-admin](https://github.com/knative-sandbox/kn-plugin-admin) and [kn-plugin-source-kafka](https://github.com/knative-sandbox/kn-plugin-source-kafka) | ||
| - The Knative Operator release with some bug fixes, and supports the latest version of knative serving and eventing. |
There was a problem hiding this comment.
| - The Knative Operator release with some bug fixes, and supports the latest version of knative serving and eventing. | |
| - The Knative Operator 0.22 release contains bug fixes, and supports version 0.22 of Knative Serving and Knative Eventing. |
| #### 💫 New Features & Changes | ||
|
|
||
| - Added an autoscaling annotation to choose a different aggregation algorithm for the autoscaling metrics. This is experimental currently. [#10840](https://github.com/knative/serving/pull/10840) | ||
| - Added autocreateClusterDomainClaims flag to network config map. [networking/#330](https://github.com/knative/networking/pull/330) |
There was a problem hiding this comment.
| - Added autocreateClusterDomainClaims flag to network config map. [networking/#330](https://github.com/knative/networking/pull/330) | |
| - Added the `autocreateClusterDomainClaims` flag to the network ConfigMap. [networking/#330](https://github.com/knative/networking/pull/330) |
|
|
||
| #### 🐞 Bug Fixes | ||
|
|
||
| - Adds validation that a default max-scale is set if a max-scale-limit is specified in the autoscaler configmap (since otherwise the default max-scale, i.e. 0 = no max, would fail validation as it is above the max-scale-limit). [#10921](https://github.com/knative/serving/pull/10921) |
There was a problem hiding this comment.
| - Adds validation that a default max-scale is set if a max-scale-limit is specified in the autoscaler configmap (since otherwise the default max-scale, i.e. 0 = no max, would fail validation as it is above the max-scale-limit). [#10921](https://github.com/knative/serving/pull/10921) | |
| - Added validation that a default `max-scale` is set if a `max-scale-limit` is specified in the autoscaler ConfigMap. Otherwise, the default `max-scale`, `0` = no max, would fail validation as it is above the `max-scale-limit`. [#10921](https://github.com/knative/serving/pull/10921) |
| #### 🐞 Bug Fixes | ||
|
|
||
| - Adds validation that a default max-scale is set if a max-scale-limit is specified in the autoscaler configmap (since otherwise the default max-scale, i.e. 0 = no max, would fail validation as it is above the max-scale-limit). [#10921](https://github.com/knative/serving/pull/10921) | ||
| - Bumped the resource request and limits of the autoscaler to 100m/100Mi, 1000m/1000Mi respectively. [#10865](https://github.com/knative/serving/pull/10865) |
There was a problem hiding this comment.
| - Bumped the resource request and limits of the autoscaler to 100m/100Mi, 1000m/1000Mi respectively. [#10865](https://github.com/knative/serving/pull/10865) | |
| - Raised the resource request and limits of the autoscaler to 100m/100Mi, 1000m/1000Mi respectively. [#10865](https://github.com/knative/serving/pull/10865) |
|
|
||
| - Adds validation that a default max-scale is set if a max-scale-limit is specified in the autoscaler configmap (since otherwise the default max-scale, i.e. 0 = no max, would fail validation as it is above the max-scale-limit). [#10921](https://github.com/knative/serving/pull/10921) | ||
| - Bumped the resource request and limits of the autoscaler to 100m/100Mi, 1000m/1000Mi respectively. [#10865](https://github.com/knative/serving/pull/10865) | ||
| - Fixed a regression where the pod bringup time might have a latency of 10s or more even though the container should be up quickly. [#10992](https://github.com/knative/serving/pull/10992) |
There was a problem hiding this comment.
| - Fixed a regression where the pod bringup time might have a latency of 10s or more even though the container should be up quickly. [#10992](https://github.com/knative/serving/pull/10992) | |
| - Fixed a regression where the latency of starting a pod could be 10s or more. [#10992](https://github.com/knative/serving/pull/10992) |
| - Adds validation that a default max-scale is set if a max-scale-limit is specified in the autoscaler configmap (since otherwise the default max-scale, i.e. 0 = no max, would fail validation as it is above the max-scale-limit). [#10921](https://github.com/knative/serving/pull/10921) | ||
| - Bumped the resource request and limits of the autoscaler to 100m/100Mi, 1000m/1000Mi respectively. [#10865](https://github.com/knative/serving/pull/10865) | ||
| - Fixed a regression where the pod bringup time might have a latency of 10s or more even though the container should be up quickly. [#10992](https://github.com/knative/serving/pull/10992) | ||
| - Reduced the necessary memory allocations in the activator significantly, especially with disabled tracing. [#11016](https://github.com/knative/serving/pull/11016), [#11013](https://github.com/knative/serving/pull/11013), [#11009](https://github.com/knative/serving/pull/11009), [#11008](https://github.com/knative/serving/pull/11008) |
There was a problem hiding this comment.
| - Reduced the necessary memory allocations in the activator significantly, especially with disabled tracing. [#11016](https://github.com/knative/serving/pull/11016), [#11013](https://github.com/knative/serving/pull/11013), [#11009](https://github.com/knative/serving/pull/11009), [#11008](https://github.com/knative/serving/pull/11008) | |
| - Reduced required memory allocations in the activator significantly, particularly when tracing is turned off. [#11016](https://github.com/knative/serving/pull/11016), [#11013](https://github.com/knative/serving/pull/11013), [#11009](https://github.com/knative/serving/pull/11009), [#11008](https://github.com/knative/serving/pull/11008) |
| - Bumped the resource request and limits of the autoscaler to 100m/100Mi, 1000m/1000Mi respectively. [#10865](https://github.com/knative/serving/pull/10865) | ||
| - Fixed a regression where the pod bringup time might have a latency of 10s or more even though the container should be up quickly. [#10992](https://github.com/knative/serving/pull/10992) | ||
| - Reduced the necessary memory allocations in the activator significantly, especially with disabled tracing. [#11016](https://github.com/knative/serving/pull/11016), [#11013](https://github.com/knative/serving/pull/11013), [#11009](https://github.com/knative/serving/pull/11009), [#11008](https://github.com/knative/serving/pull/11008) | ||
| - Fix the incorrect Gateway name format for DomainMapping auto TLS feature for net-istio implmenetation. [net-istio#532](https://github.com/knative-sandbox/net-istio/pull/532) |
There was a problem hiding this comment.
| - Fix the incorrect Gateway name format for DomainMapping auto TLS feature for net-istio implmenetation. [net-istio#532](https://github.com/knative-sandbox/net-istio/pull/532) | |
| - Fixed the incorrect gateway name format for the domain mapping auto TLS feature for `net-istio` implementation. [net-istio#532](https://github.com/knative-sandbox/net-istio/pull/532) |
|
|
||
| #### 🧹 Clean up | ||
|
|
||
| - Do not set the finalizer for pingSource for pingSource controller, just deal with it in reconcilekind [#5002](https://github.com/knative/eventing/pull/5002) |
There was a problem hiding this comment.
| - Do not set the finalizer for pingSource for pingSource controller, just deal with it in reconcilekind [#5002](https://github.com/knative/eventing/pull/5002) | |
| - Do not set a finalizer for PingSource controllers. Use `reconcilekind` instead. [#5002](https://github.com/knative/eventing/pull/5002) |
| ### Eventing Extensions | ||
|
|
||
|
|
||
| #### Eventing Kafka Broker v0.22 |
There was a problem hiding this comment.
Decide on consistent name here, @matzew any thoughts? Should this be Apache Kafka broker instead?
There was a problem hiding this comment.
I will go calling the broker "Apache Kafka Broker" and follow consistency with what we already have on the website https://knative.dev/docs/eventing/broker/kafka-broker/
| #### 🚨 Breaking or Notable | ||
|
|
||
| - Kubernetes's minimum version is 1.18. [#779](https://github.com/knative-sandbox/eventing-kafka-broker/pull/779) |
There was a problem hiding this comment.
I'd move this to way earlier in the doc; also we call this out separately earlier in the doc for the Kafka broker, so I'm not sure we need to have it in two places? The headings seem a bit messy in this blog in general, there isn't a very logical flow IMO.
There was a problem hiding this comment.
I remove it from here and leave it in the earlier "highlights" section
| - Support ordered delivery. | ||
| - You can choose between ordered and unordered delivery through the label kafka.eventing.knative.dev/delivery.order in your triggers. | ||
| - Check out the docs for more details at https://knative.dev/docs/eventing/broker/kafka-broker . [#589](https://github.com/knative-sandbox/eventing-kafka-broker/pull/) |
There was a problem hiding this comment.
Again, I feel like this was mentioned earlier but in less detail. We need a better overall structure for this doc, but we can follow that up in a future release. Won't block the PR over it.
| - Support ordered delivery. | ||
| - You can choose between ordered and unordered delivery through the label kafka.eventing.knative.dev/delivery.order in your triggers. | ||
| - Check out the docs for more details at https://knative.dev/docs/eventing/broker/kafka-broker . [#589](https://github.com/knative-sandbox/eventing-kafka-broker/pull/) |
There was a problem hiding this comment.
| - Support ordered delivery. | |
| - You can choose between ordered and unordered delivery through the label kafka.eventing.knative.dev/delivery.order in your triggers. | |
| - Check out the docs for more details at https://knative.dev/docs/eventing/broker/kafka-broker . [#589](https://github.com/knative-sandbox/eventing-kafka-broker/pull/) | |
| - The Kafka broker now supports ordered delivery. You can choose between ordered and unordered delivery by using the `kafka.eventing.knative.dev/delivery.order` label in the trigger spec. See the [Kafka broker](https://knative.dev/docs/eventing/broker/kafka-broker) documentation. [#589](https://github.com/knative-sandbox/eventing-kafka-broker/pull/) |
| - Add producer interceptor io.cloudevents.kafka.PartitionKeyExtensionInterceptor to provide ordered delivery based on the partitioning extension of the CloudEvents spec. [#751](https://github.com/knative-sandbox/eventing-kafka-broker/pull/751) | ||
| - Fix unable to deploy KafkaSink without Kafka Broker installed [#714](https://github.com/knative-sandbox/eventing-kafka-broker/pull/714) |
There was a problem hiding this comment.
| - Add producer interceptor io.cloudevents.kafka.PartitionKeyExtensionInterceptor to provide ordered delivery based on the partitioning extension of the CloudEvents spec. [#751](https://github.com/knative-sandbox/eventing-kafka-broker/pull/751) | |
| - Fix unable to deploy KafkaSink without Kafka Broker installed [#714](https://github.com/knative-sandbox/eventing-kafka-broker/pull/714) | |
| - Added a producer interceptor, `io.cloudevents.kafka.PartitionKeyExtensionInterceptor`, to provide ordered delivery based on the partitioning extension of the CloudEvents spec. [#751](https://github.com/knative-sandbox/eventing-kafka-broker/pull/751) | |
| - Fix unable to deploy KafkaSink without Kafka Broker installed [#714](https://github.com/knative-sandbox/eventing-kafka-broker/pull/714) |
| ### Client v0.22 | ||
|
|
||
| kn 0.22.0 comes with some bug fixes and minor feature enhancements. It's mostly a polishing release. If you are using the client API, there is a breaking change that was needed to align with Kubernetes client API's |
There was a problem hiding this comment.
This is mentioned already higher up in the doc, delete entirely.
There was a problem hiding this comment.
remove left it in the highlights above
| #### META | ||
| The compile dependencies have been updated to Knative Serving 0.22.0 and Knative Eventing 0.22.0. There are no changes in the used API version for communicating with the backend. |
There was a problem hiding this comment.
Move this to earlier in the doc, also the META heading is not clear. I don't think this needs a whole heading, could probably just go in the highlights section.
There was a problem hiding this comment.
I agree I removed it from the doc, is more internal info
| This release adds support for CRUD management of domain mappings. I.e. you can use `kn domain` along with its sub-commands `create`, `update`, `describe`, `list` and `delete` to fully manage DomainMapping resources for the installation of custom domains for Knative services. | ||
|
|
There was a problem hiding this comment.
| This release adds support for CRUD management of domain mappings. I.e. you can use `kn domain` along with its sub-commands `create`, `update`, `describe`, `list` and `delete` to fully manage DomainMapping resources for the installation of custom domains for Knative services. | |
| This release adds support for CRUD management of domain mappings. You can use the `kn domain` CLI command, along with its sub-commands `create`, `update`, `describe`, `list`, and `delete`, to fully manage DomainMapping resources to use custom domains for Knative services. |
| ``` | ||
| # Create a domain mappings 'hello.example.com' for Knative service 'hello' | ||
| kn domain create hello.example.com --ref hello | ||
|
|
||
| # Update a domain mappings 'hello.example.com' for Knative service 'hello' | ||
| kn domain create hello.example.com --refFlags hello | ||
|
|
||
| # List all domain mappings | ||
| kn domain list | ||
|
|
||
| # Delete domain mappings 'hello.example.com' | ||
| kn domain delete hello.example.com | ||
| ``` | ||
| See `kn domain help` for more information. | ||
|
|
There was a problem hiding this comment.
@csantanapr can you please open a docs issue for kn domain to get it properly documented in the site so it's not only explained here?
@rhuss can ya'll in the CLI group please come up with a process to make sure changes to the CLI like this are being communicated properly to docs? Otherwise they just don't get documented. CC @omerbensaadon
There was a problem hiding this comment.
Sorry for that. I will update the PR template to raise awareness, so that doc relevant PR should be properly communicated.
What would be the best way to communicate ? A ping within the PR or creating an issue in the docs repo ?
There was a problem hiding this comment.
@rhuss creating an issue in the docs repo would be perfect, thank you so much 🙂
There was a problem hiding this comment.
issues #3496 opened @abrennan89
|
|
||
| #### Client API signature change | ||
|
|
||
| A `context.Context` object is added as the first argument to every Client API method to align with Kubernetes' client API signatures. This change does not affect any client's CLI usage, only if the client-specific Golang API is used for communicating with the Knative backend has changed. The migration is straight forward, either pass an already existing context down to the call or leverage one of the available standard contexts (like `context.TODO()`). |
There was a problem hiding this comment.
Be consistent with "Client API", it's "client API" earlier in the doc, please choose one and use throughout.
There was a problem hiding this comment.
Just to make you aware I didn't write this content.
Is a copy and paste verbatim from the release notes, this blog post is just trying to put all existing release notes in a single place. The only change I do is some minor adjustments.
https://github.com/knative/client/releases/tag/v0.22.0
I think is @rhuss who writes the release notes for client
There was a problem hiding this comment.
I'm glad that tech writers are reviewing this notes, I will be happy to make any suggested changes, and then I can open an issue to the respective repos for someone with write access to release notes to update them there.
|
|
||
| #### Client API signature change | ||
|
|
||
| A `context.Context` object is added as the first argument to every Client API method to align with Kubernetes' client API signatures. This change does not affect any client's CLI usage, only if the client-specific Golang API is used for communicating with the Knative backend has changed. The migration is straight forward, either pass an already existing context down to the call or leverage one of the available standard contexts (like `context.TODO()`). |
There was a problem hiding this comment.
| A `context.Context` object is added as the first argument to every Client API method to align with Kubernetes' client API signatures. This change does not affect any client's CLI usage, only if the client-specific Golang API is used for communicating with the Knative backend has changed. The migration is straight forward, either pass an already existing context down to the call or leverage one of the available standard contexts (like `context.TODO()`). | |
| A `context.Context` object was added as the first argument to every Client API method to align with the Kubernetes client API signatures. This change does not affect client CLI usage unless the client-specific Golang API used to communicate with the Knative backend has changed. | |
| To migrate to the updated API signature, you can pass an already existing context to the call, or use one of the available standard contexts, such as `context.TODO()`. |
|
|
||
| A `context.Context` object is added as the first argument to every Client API method to align with Kubernetes' client API signatures. This change does not affect any client's CLI usage, only if the client-specific Golang API is used for communicating with the Knative backend has changed. The migration is straight forward, either pass an already existing context down to the call or leverage one of the available standard contexts (like `context.TODO()`). | ||
|
|
||
| This change does _not_ affect any CLI usage of the client. |
There was a problem hiding this comment.
Remove, already says this in the paragraph above but in more detail.
| ### CLI Plugins | ||
|
|
||
| #### 💫 New Features & Changes | ||
|
|
||
| The plugins that are released aligned with 0.22 are: | ||
|
|
||
| - [kn-plugin-admin](https://github.com/knative-sandbox/kn-plugin-admin) for managing Knative installations that are running on Kubernetes | [download](https://github.com/knative-sandbox/kn-plugin-admin/releases/tag/v0.22.0) | ||
| - [kn-plugin-source-kafka](https://github.com/knative-sandbox/kn-plugin-source-kafka) for managing a Kafka Source that has been installed via [eventing-kafka](https://github.com/knative-sandbox/eventing-kafka) on the backend | [download](https://github.com/knative-sandbox/kn-plugin-source-kafka/releases/tag/v0.22.0) |
There was a problem hiding this comment.
The new plugins are mentioned more generally in a section earlier in the doc; let's group this information maybe? It seems confusing to have it in different places.
There was a problem hiding this comment.
They are mentioned in the first section Highlights in one sentence.
- There are two new CLI plugins align with 0.22 release, [kn-plugin-admin](https://github.com/knative-sandbox/kn-plugin-admin) and [kn-plugin-source-kafka](https://github.com/knative-sandbox/kn-plugin-source-kafka)
This section is the area with the content details about the plugins.
Let me know if you want me to remove the sentence from the first section Highlights
| ### Minor CLI updates | ||
|
|
||
| - Fix `kn export` uses the _Export_ format as the default | ||
| - Added `S` column to specify built-in sources in `kn source list-types` | ||
| - Added support for namespaces for all commands that takes a `--sink` option |
There was a problem hiding this comment.
| ### Minor CLI updates | |
| - Fix `kn export` uses the _Export_ format as the default | |
| - Added `S` column to specify built-in sources in `kn source list-types` | |
| - Added support for namespaces for all commands that takes a `--sink` option | |
| ### Minor CLI updates | |
| - `kn export` now uses the _Export_ format as the default. | |
| - Added `S` column to specify built-in sources in `kn source list-types`. | |
| - Added support for namespaces for all commands that takes a `--sink` option. |
| - Delete the installed ingress resources only [#548](https://github.com/knative/operator/pull/548) | ||
| - Allow the update of ingress resources with spec.additionalManifests [#531](https://github.com/knative/operator/pull/531) | ||
| - Refactor the cache mechanism [#532](https://github.com/knative/operator/pull/532) | ||
| - Filter the redundant resources in the target manifest [#509](https://github.com/knative/operator/pull/509) |
There was a problem hiding this comment.
| - Delete the installed ingress resources only [#548](https://github.com/knative/operator/pull/548) | |
| - Allow the update of ingress resources with spec.additionalManifests [#531](https://github.com/knative/operator/pull/531) | |
| - Refactor the cache mechanism [#532](https://github.com/knative/operator/pull/532) | |
| - Filter the redundant resources in the target manifest [#509](https://github.com/knative/operator/pull/509) | |
| - Delete installed ingress resources only. [#548](https://github.com/knative/operator/pull/548) | |
| - Allow the update of ingress resources with `spec.additionalManifests`. [#531](https://github.com/knative/operator/pull/531) | |
| - Refactored the cache mechanism. [#532](https://github.com/knative/operator/pull/532) | |
| - Filter redundant resources in the target manifest. [#509](https://github.com/knative/operator/pull/509) |
There was a problem hiding this comment.
@csantanapr can we make a proper template for this going forward, my biggest issue with it is that the information seems very randomly organized, e.g. many different CLI sections throughout the doc with repeated info.
Won't block the PR on this but have added some suggestions.
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
|
/unhold |
knative-prow-robot
removed
the
do-not-merge/hold
|
@abrennan89 I made the requested changes, it should be ready now. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abrennan89 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
blog post for knative release 0.22
Closes #3485