-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add how to create custom domains with kn domain #4209
Conversation
While on it, also added how to enable TLS for the domain mapping.
✔️ Deploy Preview for knative ready! 🔨 Explore the source changes: 9b70620 🔍 Inspect the deploy log: https://app.netlify.com/sites/knative/deploys/613a32af9434b40008275719 😎 Browse the preview: https://deploy-preview-4209--knative.netlify.app |
Hi @rhuss, some of the formatting fixes will need to span lines that you've not edited in the PR, so it will be difficult for me to use the suggestion feature to suggest the correct formatting. Would it be OK to merge the PR and then open a cleanup issue for us to fix the formatting and style for you? Or would you prefer me to leave comments on the PR for you to fix the formatting yourself? |
@snneji happy to merge it now and hand it over to you to fix the formatting. So maybe give it a quick look about whether the content is fine so far ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to merge to me. Just a small fix here and the rest of the fixes can be dealt with in the cleanup issue.
One other thing - does this PR need to be cherry picked? It seems to be based on an issue that was first created for v0.22.
Co-authored-by: Samia Nneji <[email protected]>
|
wasn't there in the beginning, looks like it landed in 0.24 (same time DM went beta) |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhuss, snneji The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue to fix formatting: #4225 |
Proposed Changes
kn domain
for managing custom domainsCustomDomain
include thetls:
section for enabling HTTPSNote, that I'm not sure about the formatting as I add the
kn
usage in the middle of a numbered list and am not sure how it will be rendered. Any help for fixing the formatting is appreciated.Fixes #3496