Remove fuzzers from our binaries

[vaikas]

Describe the bug
We discovered this while looking at some fuzzer code, it was dealt with in serving:
knative/serving#9725

Expected behavior
We should not be baking in our testing libraries into our binaries.

To Reproduce
There are other binaries, but just looking at one:

vaikas@vaikas-a01 eventing % go build ./cmd/controller/main.go
vaikas@vaikas-a01 eventing % go tool nm -size main | grep fuzz
143dbe0 32 T github.com/google/gofuzz.(*Continue).ExpFloat64
143dc00 32 T github.com/google/gofuzz.(*Continue).Float32
143dc20 32 T github.com/google/gofuzz.(*Continue).Float64
143dc40 128 T github.com/google/gofuzz.(*Continue).Fuzz
143dcc0 128 T github.com/google/gofuzz.(*Continue).FuzzNoCustom
... ...

Just recording this to see what impact this may have.

vaikas@vaikas-a01 eventing % ls -l main
-rwxr-xr-x 1 vaikas staff 61121452 Oct 27 11:25 main

Knative release version
all of them.

Additional context
Add any other context about the problem here such as proposed priority

[vaikas]

Moving things into _test files, results in a small amount of reduction in binary size:
vaikas@vaikas-a01 eventing % ls -l main
-rwxr-xr-x 1 vaikas staff 61103260 Oct 27 12:00 main

vaikas@vaikas-a01 mink % echo '61121452 61103260 - p' | dc
18192

However, that change alone does not get rid of all the fuzzer code, I think we need to do some additional work in the pkg code base.

[vaikas]

Ok, we no longer have any knative.dev/* related fuzzery in our binary. However we'll tackle that later:

vaikas@vaikas-a01 eventing % go tool nm -size main | grep fuzz | wc -l
78
vaikas@vaikas-a01 eventing % go tool nm -size main | grep fuzz | grep -v github.com/google/gofuzz | wc -l
0

[vaikas]

Looks like we need to pull this commit in to get rid of the gofuzz:
kubernetes/apimachinery@08191f1#diff-44ee78478149e26a30a4185475298d442bb9e53daa49e22bc355d436aff7b144

Currently we don't have that version and we're seeing this (after the PR to rename fuzzer -> fuzzer_test.go).

github.com/google/gofuzz

knative.dev/eventing/cmd/mtbroker
k8s.io/apimachinery/pkg/apis/meta/v1
github.com/google/gofuzz

And we're still using this version:
https://github.com/knative/eventing/blob/master/vendor/k8s.io/apimachinery/pkg/apis/meta/v1/micro_time.go

[n3wscott]

We should still do this.

[vaikas]

Yeah, absolutely, but if I read the upstream correctly, we need 1.20 of the apimachinery to get this.

[github-actions]

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

[devguyio]

/remove-lifecycle stale

[github-actions]

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

[vaikas]

This is still present, even though we're using 1.20 of api machinery

vaikas@Villes-MacBook-Pro eventing % go build ./cmd/controller/main.go
vaikas@Villes-MacBook-Pro eventing % go tool nm -size main | grep fuzz | wc -l
      71

[github-actions]

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.