move fuzzers

[vaikas]

Signed-off-by: Ville Aikas [email protected]

We currently ship fuzzers in our binaries, this is hoping to remove the last bits of them. Note that I did not inline them into the roundtrip_test because I was thinking that if downstream wants to test them, they can continue to do so.

Addresses:
knative/eventing#4398
knative/serving#9725

[vaikas]

With this change, when I bring into eventing (my own branch), we now see:
vaikas@vaikas-a01 eventing % go build ./cmd/controller/main.go

vaikas@vaikas-a01 eventing % go tool nm -size  main  | grep fuzz | grep knative.dev
vaikas@vaikas-a01 eventing %

But the Google fuzzers are still there. But progress:

vaikas@vaikas-a01 eventing % go tool nm -size  main  | grep fuzz
 143dbe0         32 T github.com/google/gofuzz.(*Continue).ExpFloat64
 143dc00         32 T github.com/google/gofuzz.(*Continue).Float32
 143dc20         32 T github.com/google/gofuzz.(*Continue).Float64
 143dc40        128 T github.com/google/gofuzz.(*Continue).Fuzz

Also, down another 13kB ;)

Previously when moved the eventing fuzzers away, our resulting binary was:
61103260

vaikas@vaikas-a01 eventing % ls -l main
-rwxr-xr-x  1 vaikas  staff  61089612 Oct 27 13:26 main

vaikas@vaikas-a01 mink % echo '61103260 61089612 - p' | dc
13648

[vaikas]

UT failed with:

false}}; new config &{knative.dev/serving testComponent opencensus 1000000000 <nil> <nil> localhost:12345 false 0 false   {   false}}
    --- FAIL: TestMetricsExport/OpenCensus (4.04s)
        resource_view_test.go:439: Timeout reading input
        resource_view_test.go:445: Unexpected OpenCensus exports (-want +got):
              []metrics.metricExtract(Inverse(Sort, []string{
              	"knative.dev/serving/testComponent/global_export_counts<>:2",
              	"knative.dev/serving/testComponent/resource_global_export_count<>:2",
              	`knative.dev/serving/testComponent/testing/value<project="p1",rev`...,
            - 	`knative.dev/serving/testComponent/testing/value<project="p1",revision="r2">:1`,
              }))
    logger.go:130: 2020-10-27T11:42:23.560Z	INFO	metrics/exporter.go:155	Flushing the existing exporter before setting up the new exporter.
    logger.go:130: 2020-10-27T11:42:23.562Z	INFO	metrics/stackdriver_exporter.go:203	Created Opencensus Stackdriver exporter with config &{knative.dev/serving testComponent stackdriver 1000000000 0x22f01a0 <nil>  false 0 true knative.dev/serving/testComponent custom.googleapis.com/knative.dev/serving/testComponent {   false}}
    logger.go:130: 2020-10-27T11:42:23.562Z	INFO	metrics/exporter.go:168	Successfully updated the metrics exporter; old config: &{knative.dev/serving testComponent opencensus 1000000000 <nil> <nil> localhost:12345 false 0 false   {   false}}; new config &{knative.dev/serving testComponent stackdriver 1000000000 0x22f01a0 <nil>  false 0 true knative.dev/serving/testComponent custom.googleapis.com/knative.dev/serving/testComponent {   false}}
FAIL

I hae a hard time it's related to this, is this flaky test?

[markusthoemmes]

/lgtm
/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• apis/duck/OWNERS [markusthoemmes,vaikas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vaikas]

/test pull-knative-pkg-unit-tests

[vaikas]

Failed again with this:

    --- FAIL: TestMetricsExport/OpenCensus (4.03s)
        resource_view_test.go:439: Timeout reading input
        resource_view_test.go:445: Unexpected OpenCensus exports (-want +got):
              []metrics.metricExtract(Inverse(Sort, []string{
              	"knative.dev/serving/testComponent/global_export_counts<>:2",
              	"knative.dev/serving/testComponent/resource_global_export_count<>:2",
              	`knative.dev/serving/testComponent/testing/value<project="p1",rev`...,
            - 	`knative.dev/serving/testComponent/testing/value<project="p1",revision="r2">:1`,
              }))
    logger.go:130: 2020-10-27T11:50:08.694Z	INFO	metrics/exporter.go:155	Flushing the existing exporter before setting up the new exporter.
    logger.go:130: 2020-10-27T11:50:08.695Z	INFO	metrics/stackdriver_exporter.go:203	Created Opencensus Stackdriver exporter with config &{knative.dev/serving testComponent stackdriver 1000000000 0x22f01a0 <nil>  false 0 true knative.dev/serving/testComponent custom.googleapis.com/knative.dev/serving/testComponent {   false}}
    logger.go:130: 2020-10-27T11:50:08.695Z	INFO	metrics/exporter.go:168	Successfully updated the metrics exporter; old config: &{knative.dev/serving testComponent opencensus 1000000000 <nil> <nil> localhost:12345 false 0 false   {   false}}; new config &{knative.dev/serving testComponent stackdriver 1000000000 0x22f01a0 <nil>  false 0 true knative.dev/serving/testComponent custom.googleapis.com/knative.dev/serving/testComponent {   false}}
FAIL

/test pull-knative-pkg-unit-tests