Our binaries are shipping test packages

[dprotaso]

We're shipping our fuzzer funcs in our controllers and their dependent libraries. These are really only needed for tests so we can trim 19KB from our binaries

# go tool nm -size controller  | grep fuzz
 1293120         32 T github.com/google/gofuzz.(*Continue).ExpFloat64
 1293140         32 T github.com/google/gofuzz.(*Continue).Float32
 1293160         32 T github.com/google/gofuzz.(*Continue).Float64
 1293180        128 T github.com/google/gofuzz.(*Continue).Fuzz
 1293200        128 T github.com/google/gofuzz.(*Continue).FuzzNoCustom
 1293280         32 T github.com/google/gofuzz.(*Continue).Int
 12932a0         32 T github.com/google/gofuzz.(*Continue).Int31
 12932c0         32 T github.com/google/gofuzz.(*Continue).Int31n
 12932e0         32 T github.com/google/gofuzz.(*Continue).Int63
 1293300         32 T github.com/google/gofuzz.(*Continue).Int63n
 1293320         32 T github.com/google/gofuzz.(*Continue).Intn
 1293340         32 T github.com/google/gofuzz.(*Continue).NormFloat64
 1293360         64 T github.com/google/gofuzz.(*Continue).Perm
 12933a0        128 T github.com/google/gofuzz.(*Continue).RandBool
 1293420        128 T github.com/google/gofuzz.(*Continue).RandString
 12934a0        128 T github.com/google/gofuzz.(*Continue).RandUint64
 1293520         64 T github.com/google/gofuzz.(*Continue).Read
 1293560         32 T github.com/google/gofuzz.(*Continue).Seed
 1293580         32 T github.com/google/gofuzz.(*Continue).Shuffle
 12935a0         32 T github.com/google/gofuzz.(*Continue).Uint32
 12935c0         32 T github.com/google/gofuzz.(*Continue).Uint64
 128fde0        992 T github.com/google/gofuzz.(*Fuzzer).Funcs
 2db0e80         96 R github.com/google/gofuzz.(*Fuzzer).Funcs.stkobj
 1290600        448 T github.com/google/gofuzz.(*Fuzzer).Fuzz
 2d3f4e0         32 R github.com/google/gofuzz.(*Fuzzer).Fuzz.stkobj
 12907c0        448 T github.com/google/gofuzz.(*Fuzzer).FuzzNoCustom
 2d3f500         32 R github.com/google/gofuzz.(*Fuzzer).FuzzNoCustom.stkobj
 1290500         32 T github.com/google/gofuzz.(*Fuzzer).MaxDepth
 12902c0        128 T github.com/google/gofuzz.(*Fuzzer).NilChance
 1290340        160 T github.com/google/gofuzz.(*Fuzzer).NumElements
 12901c0        256 T github.com/google/gofuzz.(*Fuzzer).RandSource
 1290520        224 T github.com/google/gofuzz.(*Fuzzer).SkipFieldsWithPattern
 12903e0        128 T github.com/google/gofuzz.(*Fuzzer).genElementCount
 1290460        160 T github.com/google/gofuzz.(*Fuzzer).genShouldFill
 1290980       4064 T github.com/google/gofuzz.(*fuzzerContext).doFuzz
 1292ac0         32 T github.com/google/gofuzz.(*fuzzerContext).doFuzz.func1
 2d3f520         32 R github.com/google/gofuzz.(*fuzzerContext).doFuzz.stkobj
 1291960       1728 T github.com/google/gofuzz.(*fuzzerContext).tryCustom
 2db0ee0         96 R github.com/google/gofuzz.(*fuzzerContext).tryCustom.stkobj
 3a04d80         96 D github.com/google/gofuzz..inittask
 12935e0        128 T github.com/google/gofuzz.Continue.ExpFloat64
 1293660        128 T github.com/google/gofuzz.Continue.Float32
 12936e0        128 T github.com/google/gofuzz.Continue.Float64
 1292020        352 T github.com/google/gofuzz.Continue.Fuzz
 2d3f540         32 R github.com/google/gofuzz.Continue.Fuzz.stkobj
 1292180        352 T github.com/google/gofuzz.Continue.FuzzNoCustom
 2d3f560         32 R github.com/google/gofuzz.Continue.FuzzNoCustom.stkobj
 1293760         96 T github.com/google/gofuzz.Continue.Int
 12937c0         96 T github.com/google/gofuzz.Continue.Int31
 1293820        128 T github.com/google/gofuzz.Continue.Int31n
 12938a0         96 T github.com/google/gofuzz.Continue.Int63
 1293900        128 T github.com/google/gofuzz.Continue.Int63n
 1293980        128 T github.com/google/gofuzz.Continue.Intn
 1293a00        128 T github.com/google/gofuzz.Continue.NormFloat64
 1293a80        128 T github.com/google/gofuzz.Continue.Perm
 12923a0         96 T github.com/google/gofuzz.Continue.RandBool
 12922e0         96 T github.com/google/gofuzz.Continue.RandString
 1292340         96 T github.com/google/gofuzz.Continue.RandUint64
 1293b00        160 T github.com/google/gofuzz.Continue.Read
 1293ba0         96 T github.com/google/gofuzz.Continue.Seed
 1293c00        128 T github.com/google/gofuzz.Continue.Shuffle
 1293c80         96 T github.com/google/gofuzz.Continue.Uint32
 1293ce0         96 T github.com/google/gofuzz.Continue.Uint64
 3aa4308          8 B github.com/google/gofuzz.fillFuncMap
 1292400        128 T github.com/google/gofuzz.fuzzInt
 1292480        128 T github.com/google/gofuzz.fuzzUint
 1292780        128 T github.com/google/gofuzz.glob..func1
 1292800        128 T github.com/google/gofuzz.glob..func2
 1292880        160 T github.com/google/gofuzz.glob..func3
 1292920         96 T github.com/google/gofuzz.glob..func4
 1292980         96 T github.com/google/gofuzz.glob..func5
 12929e0        128 T github.com/google/gofuzz.glob..func6
 1292a60         96 T github.com/google/gofuzz.glob..func7
 1292ae0       1600 T github.com/google/gofuzz.init
 1292500        128 T github.com/google/gofuzz.randBool
 1292580        352 T github.com/google/gofuzz.randString
 12926e0        160 T github.com/google/gofuzz.randUint64
 3a89e70         32 D github.com/google/gofuzz.unicodeRanges
 3a021a0         64 D k8s.io/apimachinery/pkg/api/apitesting/fuzzer..inittask
 2392260        160 T k8s.io/apimachinery/pkg/api/apitesting/fuzzer.MergeFuzzerFuncs
 2392300        576 T k8s.io/apimachinery/pkg/api/apitesting/fuzzer.MergeFuzzerFuncs.func1
 23928c0        128 T knative.dev/pkg/apis/testing/fuzzer.(*charRange).choose
 3a09a00         96 D knative.dev/pkg/apis/testing/fuzzer..inittask
 3aa6780          8 B knative.dev/pkg/apis/testing/fuzzer.Funcs
 2392540        896 T knative.dev/pkg/apis/testing/fuzzer.FuzzConditions
 2392a60        128 T knative.dev/pkg/apis/testing/fuzzer.glob..func1
 2392ae0        608 T knative.dev/pkg/apis/testing/fuzzer.glob..func1.1
 2392d40        160 T knative.dev/pkg/apis/testing/fuzzer.init
 2392940        288 T knative.dev/pkg/apis/testing/fuzzer.randStringAtoZ

[vagababov]

/assign

[vaikas]

Did this actually fix it? As part of eventing work I was going to do this, but I was still seeing them in our binaries after moving the fuzzers into the _test*. So, I tried to back to serving to see what I had goofed up. But, yet, I still see this in the head:
vaikas@vaikas-a01 serving % go build ./cmd/controller/main.go
vaikas@vaikas-a01 serving % go tool nm -size main | grep fuzz
1293120 32 T github.com/google/gofuzz.(*Continue).ExpFloat64
1293140 32 T github.com/google/gofuzz.(*Continue).Float32
1293160 32 T github.com/google/gofuzz.(*Continue).Float64
1293180 128 T github.com/google/gofuzz.(*Continue).Fuzz
1293200 128 T github.com/google/gofuzz.(*Continue).FuzzNoCustom
1293280 32 T github.com/google/gofuzz.(*Continue).Int

1f8a5a0 128 T knative.dev/pkg/apis/testing/fuzzer.(*charRange).choose
3a2ca40 96 D knative.dev/pkg/apis/testing/fuzzer..inittask
3ac9ac8 8 B knative.dev/pkg/apis/testing/fuzzer.Funcs
1f8a220 896 T knative.dev/pkg/apis/testing/fuzzer.FuzzConditions
1f8a740 128 T knative.dev/pkg/apis/testing/fuzzer.glob..func1
1f8a7c0 608 T knative.dev/pkg/apis/testing/fuzzer.glob..func1.1
1f8aa20 160 T knative.dev/pkg/apis/testing/fuzzer.init
1f8a620 288 T knative.dev/pkg/apis/testing/fuzzer.randStringAtoZ

@dprotaso @vagababov

[vaikas]

I think we still need to do some work in pkg/ to get rid of all of these.

[vagababov]

Yeah, i think those are in ducks.