Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change webhook RBAC to talk about apps.deployments instead of v1beta1.deployments #984

Closed
vaikas opened this issue Mar 27, 2019 · 0 comments
Assignees

Comments

@vaikas
Copy link
Contributor

vaikas commented Mar 27, 2019

Problem

In the pkg/webhook we use extensions.v1beta1.deployments
but in our eventing/controller we use apps.v1.deployments

and that means that our deployments RBAC are little different between the two.

We should upgrade to latest pkg and then update these:
knative/pkg#345

Persona:
Which persona is this feature for?

Exit Criteria
once the rbac rules both use apps/deployments

Time Estimate (optional):
.2

Additional context (optional)
Add any other context about the feature request here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant