Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use apps.Deployment instead of extensions.Deployment #345

Merged
merged 2 commits into from
Mar 27, 2019
Merged

Use apps.Deployment instead of extensions.Deployment #345

merged 2 commits into from
Mar 27, 2019

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Mar 27, 2019 •
edited
Loading

Fixes: #344

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 27, 2019
@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 27, 2019
mattmoor
mattmoor reviewed Mar 27, 2019
View reviewed changes
webhook/webhook.go Outdated
@@ -42,9 +42,9 @@ import (
"github.com/mattbaird/jsonpatch"
admissionv1beta1 "k8s.io/api/admission/v1beta1"
admissionregistrationv1beta1 "k8s.io/api/admissionregistration/v1beta1"
v1 "k8s.io/api/apps/v1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: appsv1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

mattmoor
mattmoor reviewed Mar 27, 2019
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-pkg-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
webhook/webhook.go 84.3% 84.2% -0.2

@knative-prow-robot knative-prow-robot merged commit 8b3dc0d into knative:master Mar 27, 2019
@vaikas vaikas mentioned this pull request Mar 27, 2019
Closed
chengjingtao pushed a commit to katanomi/knative-pkg that referenced this pull request Oct 22, 2024
@kycheng
feat: add project manage branch equal. (knative#345)
60caa2d 
Co-authored-by: kychen <[email protected]>
chengjingtao pushed a commit to katanomi/knative-pkg that referenced this pull request Oct 22, 2024
@kycheng
feat: add project manage branch equal. (knative#345) (knative#347)
a534b76 
Co-authored-by: kychen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor left review comments

@grantr grantr Awaiting requested review from grantr

@tcnghia tcnghia Awaiting requested review from tcnghia

Assignees

@mattmoor mattmoor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vaikas @knative-prow-robot @knative-metrics-robot @mattmoor @googlebot