Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set initialDelaySeconds to 20 on webhook livenessProbe #4168

Merged
merged 1 commit into from
Oct 1, 2020
Merged

Set initialDelaySeconds to 20 on webhook livenessProbe #4168

merged 1 commit into from
Oct 1, 2020

Conversation

ian-mi
Copy link
Contributor

@ian-mi ian-mi commented Sep 29, 2020

Fixes #4165

Proposed Changes

  • Add 20 second initial delay to the liveness probe in order to give the webhook sufficient time to acquire leadership and
    reconcile eventing-webhook-certs when the leader lease duration is set to 15 seconds.

Release Note

- 🐛 Fix a bug which could cause eventing-webhook to crashloop on initial creation.

@ian-mi
Set initialDelaySeconds to 20 on webhook livenessProbe
7ae1cec 
This gives the webhook sufficient time to acquire leadership and
reconcile eventing-webhook-certs when the leader lease duration is set
to 15 seconds.
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 29, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 29, 2020
@knative-test-reporter-robot
Copy link

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-integration-tests 0/3
pull-knative-eventing-upgrade-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-integration-tests:

test/e2e.TestBrokerChannelFlowTriggerV1Beta1BrokerV1Beta1/InMemoryChannel-messaging.knative.dev/v1beta1
test/e2e.TestBrokerChannelFlowTriggerV1Beta1BrokerV1Beta1
.Test

@pierDipi pierDipi mentioned this pull request Sep 30, 2020
Merged
@vaikas
Copy link
Contributor

vaikas commented Oct 1, 2020

/test pull-knative-eventing-integration-tests
/test pull-knative-eventing-upgrade-tests

@vaikas
Copy link
Contributor

vaikas commented Oct 1, 2020

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ian-mi, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2020
@knative-prow-robot knative-prow-robot merged commit e5dbab9 into knative:master Oct 1, 2020
@JRBANCEL JRBANCEL mentioned this pull request Oct 2, 2020
Merged
@pierDipi pierDipi mentioned this pull request Oct 5, 2020
Closed
@vaikas vaikas mentioned this pull request Oct 6, 2020
Merged
@navidshaikh
Copy link
Contributor

navidshaikh commented Oct 6, 2020 •
edited
Loading

@ian-mi @vaikas : is this planned for eventing patch release v0.18.1 tomorrow today ? we're hit by this in client CI job where we test against eventing v0.18.0 release
cc: @rhuss

@vaikas
Copy link
Contributor

vaikas commented Oct 6, 2020

Hm, today? As in Tuesday? It's not been backported that I'm aware of. Let me do that now...

@vaikas vaikas mentioned this pull request Oct 6, 2020
Merged
@navidshaikh
Copy link
Contributor

yes, today ;-)

This was referenced Oct 6, 2020
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlopezgi nlopezgi Awaiting requested review from nlopezgi

@pierDipi pierDipi Awaiting requested review from pierDipi

Assignees

@vaikas vaikas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Webhook Can Enter Infinite Crashloop
6 participants
@ian-mi @knative-test-reporter-robot @vaikas @knative-prow-robot @navidshaikh @googlebot