Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.17] backport 4168 to .17 #4223

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Oct 6, 2020

Fixes #4165

Proposed Changes

Release Note

- 🐛 Fix bug
Backport #4168 which fixed #4165 

Docs

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 6, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 6, 2020
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2020
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 60caedc into knative:release-0.17 Oct 6, 2020
matzew pushed a commit to matzew/eventing that referenced this pull request Oct 6, 2020
matzew pushed a commit to matzew/eventing that referenced this pull request Oct 6, 2020
openshift-merge-robot pushed a commit to openshift/knative-eventing that referenced this pull request Oct 6, 2020
openshift-merge-robot pushed a commit to openshift/knative-eventing that referenced this pull request Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants