Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.11] Global resync brokers on config-features changes #7134

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #7126

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 1, 2023
@knative-prow knative-prow bot requested review from aliok and aslom August 1, 2023 17:18
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch coverage: 50.00% and no project coverage change.

Comparison is base (fee0553) 78.03% compared to head (541a439) 78.03%.
Report is 1 commits behind head on release-1.11.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.11    #7134   +/-   ##
=============================================
  Coverage         78.03%   78.03%           
=============================================
  Files               250      250           
  Lines             13390    13395    +5     
=============================================
+ Hits              10449    10453    +4     
- Misses             2407     2408    +1     
  Partials            534      534           
Files Changed Coverage Δ
pkg/reconciler/broker/controller.go 83.54% <50.00%> (-4.30%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-prow-robot, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2023
@pierDipi
Copy link
Member

pierDipi commented Aug 2, 2023

/test upgrade-tests

1 similar comment
@pierDipi
Copy link
Member

pierDipi commented Aug 2, 2023

/test upgrade-tests

@creydr
Copy link
Member

creydr commented Aug 2, 2023

/retest

@pierDipi
Copy link
Member

pierDipi commented Aug 2, 2023

/test upgrade-tests

@knative-prow knative-prow bot merged commit 1a5f37c into knative:release-1.11 Aug 2, 2023
15 of 17 checks passed
pierDipi added a commit to pierDipi/eventing that referenced this pull request Aug 3, 2023
…ive#7134)

This is an automated cherry-pick of knative#7126

---------

Signed-off-by: Pierangelo Di Pilato <[email protected]>
Co-authored-by: Pierangelo Di Pilato <[email protected]>
openshift-merge-robot pushed a commit to openshift-knative/eventing that referenced this pull request Aug 4, 2023
* [release-1.11] Watch config-features in IMC controller (knative#7133)

This is an automated cherry-pick of knative#7125

---------

Signed-off-by: Pierangelo Di Pilato <[email protected]>
Co-authored-by: Pierangelo Di Pilato <[email protected]>

* [release-1.11] Global resync brokers on config-features changes (knative#7134)

This is an automated cherry-pick of knative#7126

---------

Signed-off-by: Pierangelo Di Pilato <[email protected]>
Co-authored-by: Pierangelo Di Pilato <[email protected]>

---------

Signed-off-by: Pierangelo Di Pilato <[email protected]>
Co-authored-by: Knative Prow Robot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants