Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.11] Backport TLS fixes #301

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Aug 3, 2023

See individual commits and references for details.

knative-prow-robot and others added 2 commits August 3, 2023 11:34
This is an automated cherry-pick of knative#7125

---------

Signed-off-by: Pierangelo Di Pilato <[email protected]>
Co-authored-by: Pierangelo Di Pilato <[email protected]>
…ive#7134)

This is an automated cherry-pick of knative#7126

---------

Signed-off-by: Pierangelo Di Pilato <[email protected]>
Co-authored-by: Pierangelo Di Pilato <[email protected]>
@openshift-ci openshift-ci bot requested review from aliok and lberk August 3, 2023 09:36
@openshift-ci openshift-ci bot added the approved label Aug 3, 2023
@pierDipi
Copy link
Member Author

pierDipi commented Aug 3, 2023

/cc @Cali0707 @Leo6Leo @creydr @matzew

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Cali0707
Copy link
Member

Cali0707 commented Aug 4, 2023

/test 410-test-reconciler-aws-ocp-410

Copy link

@Leo6Leo Leo6Leo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same change in the knative eventing PR. lgtm!

@openshift-ci
Copy link

openshift-ci bot commented Aug 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, Leo6Leo, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit bfc115a into openshift-knative:release-v1.11 Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants