Introduce kebab-case annotation variants

[dprotaso]

Introduce alternative annotation with kebab-case to be consistent with other parts of Knative Serving.

Serving will accept these variants on public resources (Service, Route) and use the older variants for now since those are more widely supported.

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dprotaso]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dprotaso]

/hold

[codecov]

Codecov Report

Merging #562 (2ec1835) into main (23992f1) will decrease coverage by 1.40%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #562      +/-   ##
==========================================
- Coverage   94.73%   93.33%   -1.41%     
==========================================
  Files          38       38              
  Lines         798      810      +12     
==========================================
  Hits          756      756              
- Misses         30       42      +12     
  Partials       12       12              

Impacted Files	Coverage Δ
pkg/apis/networking/metadata_validation.go	100.00% <ø> (ø)
pkg/apis/networking/register.go	0.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23992f1...2ec1835. Read the comment docs.

[dprotaso]

/hold cancel

@nak3 I've simplified my approach here. It's easier if the serving controller just transforms these kebab-case annotations to the older format. This gives us time for downstream implementations to adopt the newer annotation case - if they ever do so

This satisfies knative/serving#12103

[nak3]

Sounds good. So, net-* downstream repos do not need to adopt this change for a while. Then, Is it possible to see the POC code on serving repo which uses this change?

[dprotaso]

Serving should accept these annotations once this merges since it’s using the helpers already knative/serving#12307

…

On Thu, Nov 18, 2021 at 01:49 Kenjiro Nakayama ***@***.***> wrote: Sounds good. So, net-* downstream repos do not need to adopt this change for a while. Then, Is it possible to see the POC code on serving repo which uses this change? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#562 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAERAVTOA6FL7PMSJXCT7DUMSOZDANCNFSM5IDIRQIQ> .

[nak3]

/lgtm